Rewrite docs linter, ease JSFiddle request debugging #2904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Admittedly, the request content type detection is inefficient. But it's good enough, and I wanted to do at least minimal encoding manipulation on it. Oh, and it also follows redirects and allows for retries. |
dead-claudia
force-pushed
the
jsfiddle-debug
branch
3 times, most recently
from
b354f31 to
92b4a51
Compare
dead-claudia
changed the title
|
Okay, it appears #2898 is just a flake. Will tack one extra commit to fix the outstanding issues and remove the CI debug crud, then I'll merge. |
1. I want to set the stage to deal with MithrilJS#2898 properly. 2. `request` was deprecated years ago. Decided that it's better to just move to native Node.js APIs in its place. 3. `glob` was outdated, and it's easier to just toss it than to upgrade across a major version. 4. I switched to using Marked's "lexer" directly so I'm not fussing with the complexity of renderers. This of course necessitated a more complex file processor as its "lexer" is really an AST parser. I also decided to go a few steps further: - Drop the cache to simplify everything. I might reverse this later, but just caching URLs per-page should be enough to prevent the world from crashing down. - Drop some more dependencies, so I don't have to come back to this later nearly as quickly. - Upgrade to a more modern language version in the scripts. - Update Marked. It was super outdated. - Add line and column numbers to the warnings. That took quite a bit of work, thanks to a missing Marked feature plus a bug in Marked.
dead-claudia
force-pushed
the
jsfiddle-debug
branch
from
92b4a51 to
e16fd83
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'll defer to the commit descriptions. They're self-descriptive.
The first diff is quite large.
Motivation and Context
requestis deprecated and has been for yearsThe caching I felt was unnecessary considering how uncommonly it's used. Also, it simplified the rest of the partial rewrite.
How Has This Been Tested?
I tested it locally. Now, the real test is what happens here.
Types of changes
Checklist:
docs/changelog.md