Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated dependencies inflight and glob #2900

Closed
acadiansith opened this issue Aug 19, 2024 · 4 comments
Closed

Deprecated dependencies inflight and glob #2900

acadiansith opened this issue Aug 19, 2024 · 4 comments
Assignees
Labels
Area: Workflow For anything dealing with Mithril's internal tooling, including the mocks and bundler, but not ospec Type: Bug For bugs and any other unexpected breakage

Comments

@acadiansith
Copy link

Mithril.js version: 2.2.2

Browser and OS: No browser, macOS 14.6

Project: N/A

Code

$ npm install mithril --save

Steps to Reproduce

  1. Install mithril
  2. View dependency deprecation warnings

Expected Behavior

I expected mithril to install without any warnings.

Current Behavior

I received the following two deprecation warnings for the dependencies inflight and glob when installing mithril:

npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported

In particular, inflight has been entirely deprecated by its developer a few months ago, who recommends using something else.

Context

This issue likely does not affect me, as I'm sure mithril will work just fine despite these warnings, but I thought the devs might want to be aware of this as I haven't seen it mentioned here in the issues.

@acadiansith acadiansith added the Type: Bug For bugs and any other unexpected breakage label Aug 19, 2024
@dead-claudia
Copy link
Member

dead-claudia commented Sep 1, 2024

Currently working on it in #2904. Goal is to just remove Glob entirely.

@dead-claudia
Copy link
Member

Note that you can safely ignore these errors. They're dev dependencies.

I do have a question: do you have anything like include=dev? I'm confused as to how npm would even try to be installing dev dependencies when you're not running a bare npm install.

@dead-claudia dead-claudia added the Area: Workflow For anything dealing with Mithril's internal tooling, including the mocks and bundler, but not ospec label Sep 1, 2024
@acadiansith
Copy link
Author

I'm not an npm pro by any means, but I do not think I have any particular dev mode settings specified. I installed npm via Homebrew just before setting up my Mithril project. I get the deprecation warnings on a completely clean environment:

$ mkdir test
$ cd test
$ npm init
$ np install mithril --save

with the following package.json created by npm init

{
  "name": "test",
  "version": "1.0.0",
  "description": "hello",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "me",
  "license": "ISC",
  "dependencies": {
    "mithril": "^2.2.2"
  }
}

@dead-claudia
Copy link
Member

Fixed by #2907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Workflow For anything dealing with Mithril's internal tooling, including the mocks and bundler, but not ospec Type: Bug For bugs and any other unexpected breakage
Projects
None yet
Development

No branches or pull requests

2 participants