Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New component] HiFiBerry Sound Card & OnOff SHIM #2169

Merged
merged 59 commits into from
Jan 16, 2024

Conversation

pabera
Copy link
Collaborator

@pabera pabera commented Dec 19, 2023

Add components folder to installation and docs. First component is hifiberry sound card
#2168

@pabera pabera added the future3 Relates to future3 development label Dec 19, 2023
@pabera pabera self-assigned this Dec 19, 2023
@pabera pabera force-pushed the future3/hifiberry-doc branch from 705c277 to d0f325d Compare December 19, 2023 07:43
@pabera pabera force-pushed the future3/hifiberry-doc branch from d0f325d to 6475eeb Compare December 19, 2023 07:43
@s-martin
Copy link
Collaborator

I followed this guide:
https://www.hifiberry.com/docs/software/configuring-linux-3-18-x/

I used miniamp

@pabera
Copy link
Collaborator Author

pabera commented Dec 19, 2023

Yes. i will update the script to have all these options.

documentation/builders/components/hifiberry.md Outdated Show resolved Hide resolved
documentation/builders/components/Readme.md Outdated Show resolved Hide resolved
documentation/builders/components/Readme.md Outdated Show resolved Hide resolved
documentation/builders/components/hifiberry.md Outdated Show resolved Hide resolved
installation/components/setup_hifiberry.sh Outdated Show resolved Hide resolved
installation/components/setup_hifiberry.sh Outdated Show resolved Hide resolved
installation/components/setup_hifiberry.sh Outdated Show resolved Hide resolved
installation/components/setup_hifiberry.sh Outdated Show resolved Hide resolved
installation/components/setup_hifiberry.sh Outdated Show resolved Hide resolved
installation/components/setup_hifiberry.sh Outdated Show resolved Hide resolved
@s-martin
Copy link
Collaborator

I just remembered that the RFID reader configuration can trigger Python dependencies or custom shell scripts, see https://github.com/MiczFlor/RPi-Jukebox-RFID/blob/future3%2Fdevelop/src%2Fjukebox%2Fcomponents%2Frfid%2Fconfigure%2F__init__.py#L16

Could be worth it to think of a similar mechanism for soundcards or other hardware, if they need a script.

@kosli
Copy link

kosli commented Dec 30, 2023

Isn't phoniebox 3 / future3 based on the bookworm debian images? so the config.txt should be in /boot/firmware/config.txt and not /boot/config.txt -> this took me a while to find out why hifiberry-dac was not loaded.
see the first paragraph in https://www.raspberrypi.com/documentation/computers/config_txt.html

@AlvinSchiller
Copy link
Collaborator

You are right with the changed path for bookworm.

There are a few changes to bookworm which just came up and haven't been addressed yet (e.g. network manager). We have to look into this.

Strange that this worked in my case.

@pabera
Copy link
Collaborator Author

pabera commented Dec 30, 2023

Thanks a lot for your input. Sorry to hear that you struggle to find initially.

Isn't phoniebox 3 / future3 based on the bookworm debian images?

future3 supports both versions, Bullseye and Bookwork.

I did test these changes on my current Pi Zero 2. The suggested Debian version (by Pi Imager) for this hardware is still Bullseye. But it seems to be true that this is different for Bookworm. I will take care of this in another commit.

@team: We will have to adapt our documentation as /boot/config.txt is referenced in different places.

@s-martin
Copy link
Collaborator

Although I couldn't find any info that the hardware is the same as hifiberry, the I2S PCM5102A DAC soundcard seems to need the same configuration: #1886 (comment)

documentation/builders/components/power/onoff-shim.md Outdated Show resolved Hide resolved
documentation/builders/components/soundcards/hifiberry.md Outdated Show resolved Hide resolved
documentation/builders/components/soundcards/hifiberry.md Outdated Show resolved Hide resolved
documentation/builders/components/soundcards/hifiberry.md Outdated Show resolved Hide resolved
installation/includes/02_helpers.sh Outdated Show resolved Hide resolved
installation/includes/02_helpers.sh Outdated Show resolved Hide resolved
installation/options/onboard_sound.sh Show resolved Hide resolved
installation/options/onboard_sound.sh Show resolved Hide resolved
installation/components/setup_hifiberry.sh Outdated Show resolved Hide resolved
```

* [Source](https://shop.pimoroni.com/products/onoff-shim?variant=41102600138)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add how to customize the shutdown command, so the Phoniebox shutdown is used (that's why I was working on pbc.c and run_rpc_tool.py).

I could add something tonight.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preferably, add it directly to this PR

documentation/builders/components/soundcards/hifiberry.md Outdated Show resolved Hide resolved
documentation/builders/components/soundcards/hifiberry.md Outdated Show resolved Hide resolved
documentation/builders/components/soundcards/hifiberry.md Outdated Show resolved Hide resolved
installation/options/onboard_sound.sh Show resolved Hide resolved
@pabera pabera mentioned this pull request Jan 15, 2024
13 tasks
installation/options/onboard_sound.sh Outdated Show resolved Hide resolved
installation/components/setup_hifiberry.sh Outdated Show resolved Hide resolved
installation/components/setup_hifiberry.sh Outdated Show resolved Hide resolved
installation/components/setup_hifiberry.sh Outdated Show resolved Hide resolved
@pabera pabera added this to the v3.5 milestone Jan 16, 2024
@pabera pabera merged commit 03e6197 into MiczFlor:future3/develop Jan 16, 2024
17 checks passed
@pabera pabera deleted the future3/hifiberry-doc branch January 16, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement future3 Relates to future3 development installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants