-
-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @Extensions decorator #521
Add @Extensions decorator #521
Conversation
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
==========================================
- Coverage 95.18% 94.93% -0.26%
==========================================
Files 76 77 +1
Lines 1330 1361 +31
Branches 257 264 +7
==========================================
+ Hits 1266 1292 +26
- Misses 61 66 +5
Partials 3 3
Continue to review full report at Codecov.
|
@MichalLytek Hmm my mistake 🙁I did enable this option but it seems our organization rules override it, I have added an invitation on the repo for you, it should enable you to push changes if you accept it If it does not, I will fork again on my personal account, sorry for the inconvenience. |
@hihuz I think you've forgot to setup container in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now everything looks great! 🎉
Thank you very much for the contribution ❤️
@MichalLytek Thank you very much for all the time you spent looking at the PR and for all the feedback, much appreciated 🙂 Apologies for the remaining issue with the examples 🤦♂ and thank you for fixing it 👍 |
Hello 👋
First of all, thank you very much for your work on this library, it has helped us a lot in rapidly creating a graphql endpoint to go hand in hand with our existing REST API 🙂
In this PR, I will attempt to address this issue: #124
I have tried to base my implementation off of the comments I could read in the issue and also in the PRs that were previously created for this. I also took inspiration from the Directive PR (#369) which helped me by showcasing recent good PR practices on the project.
I will leave several comments of my own where I am unsure about my approach, I would be grateful if you could let me know your views on them, and also for any time you would spend reviewing the PR.
I won't be very active during the upcoming week-end, but I'll definitely try to address any feedback as fast as I can during the next week.
Best!