Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extensions metadata Decorator #512

Closed

Conversation

hihuz
Copy link
Contributor

@hihuz hihuz commented Jan 8, 2020

No description provided.

@hihuz
Copy link
Contributor Author

hihuz commented Jan 8, 2020

Sorry, didn't mean to create the PR this early, closing for now.

@hihuz hihuz closed this Jan 8, 2020
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #512 into master will decrease coverage by 0.46%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
- Coverage   95.18%   94.72%   -0.47%     
==========================================
  Files          76       77       +1     
  Lines        1330     1346      +16     
  Branches      257      259       +2     
==========================================
+ Hits         1266     1275       +9     
- Misses         61       68       +7     
  Partials        3        3
Impacted Files Coverage Δ
src/schema/schema-generator.ts 96.74% <ø> (ø) ⬆️
src/decorators/index.ts 100% <100%> (ø) ⬆️
src/decorators/Extensions.ts 42.85% <42.85%> (ø)
src/metadata/metadata-storage.ts 97.98% <62.5%> (-2.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe6b306...9dfef70. Read the comment docs.

@MichalLytek
Copy link
Owner

@hihuz Feel free to reopen when it's ready

@hihuz
Copy link
Contributor Author

hihuz commented Jan 10, 2020

I ended up creating a different PR, hope you don't mind: #521 🙂

@MichalLytek MichalLytek added the Invalid 👎 This doesn't seem right label Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid 👎 This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants