Fix transforming and validating nested inputs and arrays

[MichalLytek]

Closes #133 🔒

[MichalLytek]

@j Please review the changes - they are based on your #452 PR 😉

[codecov]

Codecov Report

Merging #462 into master will increase coverage by 0.28%.
The diff coverage is 98.63%.

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   94.74%   95.03%   +0.28%     
==========================================
  Files          74       75       +1     
  Lines        1238     1310      +72     
  Branches      234      247      +13     
==========================================
+ Hits         1173     1245      +72     
  Misses         62       62              
  Partials        3        3

Impacted Files	Coverage Δ
src/schema/schema-generator.ts	96.69% <ø> (ø)	⬆️
src/resolvers/convert-args.ts	100% <100%> (ø)
src/resolvers/helpers.ts	100% <100%> (ø)	⬆️
src/resolvers/validate-arg.ts	100% <100%> (ø)	⬆️
src/helpers/types.ts	98.21% <50%> (+0.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c81f4...430918d. Read the comment docs.

[j]

@MichalLytek looks like familiar code! :P haha but looks great. I'll get to playing with it soon. I moved forward with a lot of internal development and was going to add validation at some point later. Thanks for this.

[MichalLytek]

@j Soooo have you checked the changes? Does it work with edge use cases? 😄

[j]

@MichalLytek woops, I wrote that on my phone and thought it was merged. I'll test this now.

[j]

@MichalLytek based on our current code-base where we use inheritance on the root level of an input and nested inputs, I was able to confirm that validation works and all inputs are mapped correctly. I toyed with doing deep nested with inheritance and those were converted properly as well.

Thanks for this!

[j]

@MichalLytek one thing I just saw, and I'm not sure if this is a bug or not. If you have a nullable input, it's creating the object with undefined fields.

[j]

Extra info:

The below mutation has a nullable input, in this case, I left it out and errors happen.

mutation createCart {
  createCart {
     ...
  }
}

[
            "TypeError: Cannot read property 'email' of undefined",
            "    at tree.getFields.reduce (/Users/graphql/node_modules/type-graphql/dist/resolvers/convert-args.js:54:27)",
            "    at Array.reduce (<anonymous>)",
            "    at convertToInput (/Users/graphql/node_modules/type-graphql/dist/resolvers/convert-args.js:52:42)",
            "    at convertValueToInstance (/Users/graphql/node_modules/type-graphql/dist/resolvers/convert-args.js:71:11)",
            "    at convertValuesToInstances (/Users/graphql/node_modules/type-graphql/dist/resolvers/convert-args.js:78:12)",
            "    at Object.convertArgToInstance (/Users/graphql/node_modules/type-graphql/dist/resolvers/convert-args.js:104:12)",
            "    at Object.<anonymous> (/Users/graphql/node_modules/type-graphql/dist/resolvers/helpers.js:17:76)",
            "    at Generator.next (<anonymous>)",
            "    at /Users/graphql/node_modules/tslib/tslib.js:110:75",
            "    at new Promise (<anonymous>)"
          ]

[MichalLytek]

Thanks for the report, @j! That's the use cases I was thinking of 😄

I've checked the nullable fields but they are handled by convertToType.
But the if the value of nullable arg @Arg("input", { nullable: true }) input?: SampleNestedInput is null, then it failed, so I've fixed it 💪

If you have a nullable input, it's creating the object with undefined fields.

It's still the same case like with the createCart and Cannot read property 'email' of undefined? Or it's a different one cause I don't know how to reproduce that.

[j]

@MichalLytek yup, that ended up fixing the error! 💪

[MichalLytek]

@j Thanks for confirmation!

Merging 👀