POC: nested input support #452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
+ Coverage 94.65% 94.75% +0.09%
==========================================
Files 71 72 +1
Lines 1160 1201 +41
Branches 218 227 +9
==========================================
+ Hits 1098 1138 +40
Misses 59 59
- Partials 3 4 +1
Continue to review full report at Codecov.
|
|
/cc @MichalLytek |
This was referenced Oct 29, 2019
MichalLytek
added
Community 👨👧
MichalLytek
requested changes
Nov 10, 2019
|
@j Your idea is good! 💪 I will try to work on this to support all cases like |
|
Closing in favor of #462 🔒 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing inputs.
I'm doing this by iterating over the input type fields, checking if the field's type is an input type, and if so, hydrating the argument into the class. I attempted to make it more performant by caching the tree based off the param metadata's type.