Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMAROC-819 Add support for numpy >2.0 #129

Merged
merged 3 commits into from
Jun 26, 2024
Merged

AMAROC-819 Add support for numpy >2.0 #129

merged 3 commits into from
Jun 26, 2024

Conversation

fpavogt
Copy link
Member

@fpavogt fpavogt commented Jun 25, 2024

Description:

This PR fixes a handful of deprecations related to numpy 2.0.0. Note that these changes should be backward compatible.

Error(s) fixed:

Checklists:

  • New code includes dedicated tests.
  • New code has been linted.
  • New code follows the project's style.
  • New code is compatible with the 3-Clause BSD license.
  • CHANGELOG has been updated.
  • AUTHORS has been updated.
  • Copyright years in module docstrings have been updated.

@fpavogt fpavogt self-assigned this Jun 25, 2024
@fpavogt fpavogt added this to the v2.0.0 milestone Jun 25, 2024
@fpavogt fpavogt marked this pull request as ready for review June 25, 2024 18:17
@fpavogt fpavogt requested a review from regDaniel June 25, 2024 18:17
@fpavogt
Copy link
Member Author

fpavogt commented Jun 25, 2024

Hey @regDaniel, the required changes were not too bad. If it looks good to you, I'll merge this into develop. Let me know.

regDaniel
regDaniel approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@regDaniel regDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fpavogt ! I'm glad to hear it wasn't too bad. I'll close the other MR then.

@regDaniel regDaniel mentioned this pull request Jun 26, 2024
Closed
7 tasks
@fpavogt fpavogt changed the title Add support for numpy >2.0 AMAROC-819 Add support for numpy >2.0 Jun 26, 2024
@fpavogt fpavogt merged commit 00bfab6 into develop Jun 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regDaniel regDaniel regDaniel approved these changes

Assignees

@fpavogt fpavogt

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fpavogt @regDaniel