Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMAROC-818 fix versions #128

Closed

Conversation

regDaniel
Copy link
Collaborator

@regDaniel regDaniel commented Jun 24, 2024

Description:

Fixes numpy version to < 2.0 to avoid attribute errors raised due to backward incompatibilities. Should fix the weekly test pipeline.

Error(s) fixed:

Fixed https://meteoswiss.atlassian.net/browse/AMAROC-818

Checklists:

  • New code includes dedicated tests.
  • New code has been linted.
  • New code follows the project's style.
  • New code is compatible with the 3-Clause BSD license.
  • CHANGELOG has been updated.
  • AUTHORS has been updated.
  • Copyright years in module docstrings have been updated.

@regDaniel regDaniel requested a review from fpavogt June 24, 2024 15:57
@regDaniel
Copy link
Collaborator Author

@fpavogt I assigned you for review because you set up the actions pipeline. I can however also assign someone else if you prefer.

@fpavogt
Copy link
Member

fpavogt commented Jun 25, 2024

What about fixing the issues ? As far as I can tell, the only problems are link to the use of np.infty that should be replaced with np.inf, and np.in1d by np.isin.

These modifications should be backward compatible ... What do you think ? Is there something deeper that we should be cautious about ?

@regDaniel
Copy link
Collaborator Author

Hi @fpavogt sorry, I should have mentioned: I opened a ticket for that already. Here I just went for the fastest solution (priorities) in order to make the weekly pipeline run again, but fixing the issues is already planned.

@regDaniel
Copy link
Collaborator Author

obsolete with #129

@regDaniel regDaniel closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants