Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tokens search discovery controller #13111

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Bigshmow
Copy link

@Bigshmow Bigshmow commented Jan 22, 2025

Description

This PR introduces the @metamask/token-search-discovery-controller to mobile. The package provides token search functionality via the Portfolio API & Moralis, which will enable the front end to implement a token search view.

We have created a factory function to introduce the class into Engine context, and redux selectors and a custom hook were added as well as some tests.

See MMPD-1504 MMPD-1526 in Jira for added context.

Related issues

Fixes:

Manual testing steps

  1. This change introduces a dependency so I don't think there is a need for manual testing steps.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Bigshmow Bigshmow changed the title Add tokens search discovery controller feat: add tokens search discovery controller Jan 22, 2025
@Bigshmow Bigshmow added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 22, 2025
Copy link
Contributor

github-actions bot commented Jan 22, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 02b04ed
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/372d049b-9ead-4aaa-b2b1-4227411aa4c0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

socket-security bot commented Jan 22, 2025

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] network 0 55.3 kB metamaskbot

View full report↗︎

Copy link

socket-security bot commented Jan 22, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@Bigshmow Bigshmow added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 22, 2025
Copy link
Contributor

github-actions bot commented Jan 22, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ab3aa5b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/56b818a8-f0ba-4d4f-81b4-d34834eeb739

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Bigshmow
Copy link
Author

@SocketSecurity ignore npm/@metamask/[email protected]

@Bigshmow Bigshmow marked this pull request as ready for review January 22, 2025 19:26
@Bigshmow Bigshmow requested review from a team as code owners January 22, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-portfolio
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

2 participants