Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js-ts): Convert app/components/Views/OnboardingSuccess/index.test.js to TypeScript #11397

Closed
wants to merge 11 commits into from
+22 −7
Closed

chore(js-ts): Convert app/components/Views/OnboardingSuccess/index.test.js to TypeScript #11397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3d32bf8
chore(js-ts): Convert app/components/Views/OnboardingSuccess/index.te…
devin-ai-integration[bot] Sep 23, 2024
2f91540
Convert index.test.js to TypeScript
devin-ai-integration[bot] Sep 23, 2024
4f84fc4
chore: Rename snapshot file to .ts.snap
devin-ai-integration[bot] Sep 23, 2024
d23b53f
chore: Rename snapshot file to .tsx.snap
devin-ai-integration[bot] Sep 23, 2024
2b37691
Fix test for OnboardingSuccess component
devin-ai-integration[bot] Sep 23, 2024
88c16e1
fix: Remove unused import in index.test.tsx
devin-ai-integration[bot] Sep 23, 2024
46f752f
chore: Update snapshot for OnboardingSuccess component
devin-ai-integration[bot] Sep 23, 2024
0db20a2
commit to trigger CI
devin-ai-integration[bot] Sep 25, 2024
739508a
commit to trigger CI
devin-ai-integration[bot] Sep 25, 2024
e367b61
fixing review comments
devin-ai-integration[bot] Oct 1, 2024
f2e7c45
fixing snapshot
devin-ai-integration[bot] Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...gSuccess/__snapshots__/index.test.js.snap → ...Success/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ Change these at any time.
accessibilityRole="button"
accessible={true}
activeOpacity={1}
onPress={[MockFunction]}
onPressIn={[Function]}
onPressOut={[Function]}
style={
Expand Down
28 changes: 21 additions & 7 deletions ...nts/Views/OnboardingSuccess/index.test.js → ...ts/Views/OnboardingSuccess/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@ import React from 'react';
// Internal dependencies.
import OnboardingSuccess from './';
import renderWithProvider from '../../../util/test/renderWithProvider';
import { useNavigation } from '@react-navigation/native';
import { useSelector } from 'react-redux';
import { selectProviderConfig } from '../../../selectors/networkController';
import { selectProviderConfig, ProviderConfig } from '../../../selectors/networkController';

jest.mock('@react-navigation/native', () => {
const actualReactNavigation = jest.requireActual('@react-navigation/native');
Expand All @@ -29,19 +28,34 @@ jest.mock('react-redux', () => ({
useSelector: jest.fn(),
}));

const mockProviderConfig = {
const mockProviderConfig: ProviderConfig = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ProviderConfig from app/selectors/networkController.ts instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the ProviderConfig interface defined in this file

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cal-L done

type: 'mainnet',
chainId: '1',
chainId: '0x1',
ticker: '',
rpcUrl: '',
nickname: undefined
};

describe('OnboardingSuccess', () => {
it('should render correctly', () => {
useSelector.mockImplementation((selector) => {
(useSelector as jest.Mock).mockImplementation((selector: typeof selectProviderConfig) => {
if (selector === selectProviderConfig) return mockProviderConfig;
});
const { toJSON } = renderWithProvider(
<OnboardingSuccess navigation={useNavigation()} />,
const mockOnDone = jest.fn();
const { getByTestId, toJSON } = renderWithProvider(
<OnboardingSuccess onDone={mockOnDone} backedUpSRP={false} noSRP={false} />,
);

// Snapshot test
expect(toJSON()).toMatchSnapshot();

const doneButton = getByTestId('onboarding-success-done-button');
expect(doneButton).toBeTruthy();

// Simulate button press
doneButton.props.onPress();

// Check if mockOnDone was called
expect(mockOnDone).toHaveBeenCalledTimes(1);
});
});
Loading