Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(js-ts): Convert app/components/Views/OnboardingSuccess/index.test.js to TypeScript #11397

Closed
wants to merge 11 commits into from
Closed

chore(js-ts): Convert app/components/Views/OnboardingSuccess/index.test.js to TypeScript #11397

wants to merge 11 commits into from
+22 −7

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Sep 23, 2024 •
edited
Loading

Description

This pull request converts the file app/components/Views/OnboardingSuccess/index.test.js to TypeScript. The conversion involved renaming the file to index.test.tsx, inferring types, and resolving TypeScript errors. The old .js file has been removed.

Related Issues

N/A

Manual Testing Steps

  1. Run yarn tsc to ensure there are no TypeScript errors.
  2. Run yarn lint to ensure there are no lint errors.
  3. Verify that the tests in index.test.tsx pass successfully.

Checklist

  • Converted index.test.js to TypeScript.
  • Removed the old .js file.
  • Ensured no TypeScript errors with yarn tsc.
  • Ensured no lint errors with yarn lint.
  • Added appropriate labels to the pull request.

This Devin run was requested by Moritz.

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner September 23, 2024 20:55
@devin-ai-integration devin-ai-integration bot added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform No QA Needed Apply this label when your PR does not need any QA effort. labels Sep 23, 2024
@github-actions github-actions bot added the team-ai AI team (for the Devin AI bot) label Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Cal-L
Cal-L reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

app/components/Views/OnboardingSuccess/index.test.tsx
@@ -29,19 +34,31 @@ jest.mock('react-redux', () => ({
useSelector: jest.fn(),
}));

const mockProviderConfig = {
const mockProviderConfig: ProviderConfig = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ProviderConfig from app/selectors/networkController.ts instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the ProviderConfig interface defined in this file

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cal-L done

@devin-ai-integration devin-ai-integration bot added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Sep 25, 2024
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

Triggering CI rerun

@devin-ai-integration devin-ai-integration bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 739508a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e5885731-7cf4-4b88-b928-55567df7bef7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Dec 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

@github-actions github-actions bot closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Devin-Apps Devin-Apps Devin-Apps left review comments

@Cal-L Cal-L Cal-L left review comments

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. stale Issues that have not had activity in the last 90 days team-ai AI team (for the Devin AI bot) team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cal-L @Devin-Apps