Added Font Scaling Helper Methods to FlatLafStyleBuilder
#6116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented new static methods to allow setting font scaling for `JComponents` with optional bold text and custom font names. These helper functions are designed to streamline usage of the `FlatLafStyleBuilder`.
Replaced direct font builder calls with a static setFontScaling method in both MMToggleButton and ScenarioInfoPanel classes. This change promotes code reuse and simplifies the font scaling process for UI components.
Replaced direct font style application with setFontScaling method. This change improves readability and maintainability by centralizing font scaling logic.
A new method `setFontScaling` was added to set font scaling for a component with default parameters. This method simplifies setting the default font ("MekHQ"), with no bold text, and a default size of 1.
Replaced hardcoded "MekHQ" font with MMConstants.FONT_DIALOG to improve consistency and maintainability. This change ensures that the default dialog font is used throughout the application, facilitating easier future updates.
|
I've had second thoughts about these changes. Closing branch. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6116 +/- ##
============================================
- Coverage 29.07% 29.07% -0.01%
+ Complexity 13971 13970 -1
============================================
Files 2601 2601
Lines 267448 267458 +10
Branches 47758 47758
============================================
- Hits 77765 77764 -1
- Misses 185788 185798 +10
- Partials 3895 3896 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented new static methods to allow setting font scaling for
JComponents. These helper functions are designed to streamline usage of theFlatLafStyleBuilder.