Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario Chooser fix #6072

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Scenario Chooser fix #6072

merged 2 commits into from
Oct 7, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Oct 6, 2024

Fixes a minor issue where pressing "OK" in the MM scenario chooser without having selected a scenario results in an NPE.

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.11%. Comparing base (ef8b224) to head (77924f4).
Report is 34 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6072      +/-   ##
============================================
+ Coverage     29.06%   29.11%   +0.05%     
+ Complexity    13980    13979       -1     
============================================
  Files          2600     2601       +1     
  Lines        267592   267077     -515     
  Branches      47795    47744      -51     
============================================
- Hits          77770    77769       -1     
+ Misses       185915   185402     -513     
+ Partials       3907     3906       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SJuliez SJuliez merged commit 23b8d60 into MegaMek:master Oct 7, 2024
6 checks passed
@SJuliez SJuliez deleted the scenario-chooser-fix branch October 15, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants