#6061: Restore Altitude Behavior for Princess Deploying Aero #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6071 +/- ##
============================================
+ Coverage 29.06% 29.11% +0.05%
+ Complexity 13980 13979 -1
============================================
Files 2600 2601 +1
Lines 267584 267091 -493
Branches 47791 47748 -43
============================================
- Hits 77770 77769 -1
+ Misses 185907 185416 -491
+ Partials 3907 3906 -1 ☔ View full report in Codecov by Sentry. |
kuronekochomusuke
approved these changes
Oct 6, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6061
With the updated deployment options (for human players), some code in GameManager that simply set the altitude of deployed aeros to 5 was removed. Therefore some Princess code is required. Princess can deploy DS grounded, when the altitude is set to 0 in the lobby.