Replace Manual GUI scaling with FlatLaf Scaling #6068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
CodeQL warnings are because I marked the old html methods as deprecated. No real problem |
HammerGS
approved these changes
Oct 5, 2024
kuronekochomusuke
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes most of the code of the old manual GUI scaling and replaces it with Flatlaf's built in scaling. It leaves some of the HTML-related methods in UIUtil and just "de-arms" and renames them as the tooltips make heavy use of them and I think we should rewrite those with CSS anyway. This PR also adds a util class for adding font and style to swing components using flatlaf's clientproperty style. The advantage of this is that it is less hassle than using setFont() and scales effortlessly.
If anyone reviews this, better turn off whitespace changes. It's still a lot.
Merge together with MHQ #4989