Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better display of radical heat sinking in preview #6033

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

pavelbraginskiy
Copy link
Collaborator

@pavelbraginskiy pavelbraginskiy commented Sep 24, 2024

Instead of a weird calculation based on trying to average the heat sinking capacity with and without radical heat sinks, show both the capacity with and without Radical Heat Sinks/Coolant Pod/RISC Emergency Coolant System.

Coolant Pod:
image

Radical Heat Sink System:
image

RISC ECS:
image

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.10%. Comparing base (b8ce280) to head (c9f257a).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6033   +/-   ##
=========================================
  Coverage     29.10%   29.10%           
- Complexity    13972    13977    +5     
=========================================
  Files          2580     2580           
  Lines        267143   267165   +22     
  Branches      47711    47717    +6     
=========================================
+ Hits          77743    77756   +13     
- Misses       185502   185505    +3     
- Partials       3898     3904    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 7dcbf06 into MegaMek:master Sep 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants