Weapon Handler Comment cleanup #6025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6025 +/- ##
============================================
- Coverage 29.10% 29.10% -0.01%
+ Complexity 13973 13972 -1
============================================
Files 2580 2580
Lines 267140 267143 +3
Branches 47709 47711 +2
============================================
- Hits 77744 77743 -1
- Misses 185499 185502 +3
- Partials 3897 3898 +1 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
HammerGS
approved these changes
Sep 21, 2024
|
If there is a variable in the parent class with the same name, they don't need to be redeclared and can cause issues |
# Conflicts: # megamek/src/megamek/common/weapons/ACCaselessHandler.java # megamek/src/megamek/common/weapons/PrimitiveACWeaponHandler.java # megamek/src/megamek/common/weapons/PrototypeACWeaponHandler.java
rjhancock
reviewed
Sep 22, 2024
megamek/src/megamek/common/weapons/ASEWMissileWeaponHandler.java
Outdated
Show resolved
Hide resolved
rjhancock
reviewed
Sep 22, 2024
rjhancock
approved these changes
Sep 22, 2024
rjhancock
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 99% comment cleanup in the weapon handler classes, removing those "non-javadoc"s, updating the copyrights, removing empty javadocs (I didnt bother filling in the constructor javadocs, as they mostly just call super). And maybe 3 minor and obvious code updates.