Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Entity cleanup #6004

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Some Entity cleanup #6004

merged 1 commit into from
Sep 16, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Sep 15, 2024

Code updates for Entity in the hope of making it shorter and removing warnings

  • removes almost all unused methods
  • code updates like new switch statements and instaneof pattern variables, most of them one-click suggestions by the IDE
  • other updates to remove warnings like incomplete javadoc

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.09%. Comparing base (07a8bb0) to head (96e1119).
Report is 16 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6004      +/-   ##
============================================
+ Coverage     29.07%   29.09%   +0.02%     
+ Complexity    13958    13957       -1     
============================================
  Files          2576     2576              
  Lines        267398   267183     -215     
  Branches      47803    47718      -85     
============================================
+ Hits          77735    77737       +2     
+ Misses       185761   185541     -220     
- Partials       3902     3905       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SJuliez SJuliez merged commit ce87003 into MegaMek:master Sep 16, 2024
5 checks passed
@SJuliez SJuliez deleted the entity-clean branch October 15, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants