Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test QOL Changes #6001

Merged
merged 4 commits into from
Sep 15, 2024
Merged

Test QOL Changes #6001

merged 4 commits into from
Sep 15, 2024

Conversation

rjhancock
Copy link
Collaborator

Removes public that isn't needed from class and method definitions.
Segments some tests into individual ones to better clarify what they are for.
Fixes the unit count test to ensure loaded files match processed files.
Removed dead tests.

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.07%. Comparing base (07a8bb0) to head (f844c90).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6001   +/-   ##
=========================================
  Coverage     29.07%   29.07%           
+ Complexity    13958    13956    -2     
=========================================
  Files          2576     2576           
  Lines        267398   267398           
  Branches      47803    47803           
=========================================
+ Hits          77735    77740    +5     
+ Misses       185761   185755    -6     
- Partials       3902     3903    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjhancock rjhancock merged commit 47235cc into MegaMek:master Sep 15, 2024
5 checks passed
@rjhancock rjhancock deleted the test-qol-cleanup branch September 15, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant