Mech -> Mek updates. #5981
Mech -> Mek updates. #5981
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5981 +/- ##
============================================
+ Coverage 28.85% 29.07% +0.21%
+ Complexity 13981 13957 -24
============================================
Files 2580 2576 -4
Lines 269204 267397 -1807
Branches 48042 47803 -239
============================================
+ Hits 77691 77733 +42
+ Misses 187538 185761 -1777
+ Partials 3975 3903 -72 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| !(movingUnit instanceof Protomech))) { | ||
| if (Mek.LOC_HEAD == loc || | ||
| Mek.LOC_CT == loc || | ||
| ProtoMek.LOC_HEAD == loc || |
Check warning
Code scanning / CodeQL
Useless comparison test Warning
| * @param playerId The ID of the player owning the target. | ||
| * @return TRUE if the unit is on the broken units list without being on the honorless enemies list. | ||
| */ | ||
| boolean isEnemyBroken(int targetid, int playerId, boolean forcedWithdrawal); | ||
| boolean isEnemyBroken(int targetId, int playerId, boolean forcedWithdrawal); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| precogThread = new Thread(precognition, "Princess-precognition (" + getName() + ")"); | ||
| precogThread.start(); | ||
| precognitionThread = new Thread(precognition, "Princess-precognition (" + getName() + ")"); | ||
| precognitionThread.start(); |
Check warning
Code scanning / CodeQL
Start of thread in constructor Warning
| } else { | ||
| target = new Coords(Integer.parseInt(args[1]) - 1, Integer | ||
| .parseInt(args[2]) - 1); | ||
| target = new Coords(Integer.parseInt(args[1]) - 1, Integer.parseInt(args[2]) - 1); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
| } else { | ||
| target = new Coords(Integer.parseInt(args[1]) - 1, Integer | ||
| .parseInt(args[2]) - 1); | ||
| target = new Coords(Integer.parseInt(args[1]) - 1, Integer.parseInt(args[2]) - 1); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
| } | ||
|
|
||
| if (target == null && args.length > 3) { | ||
| target = new Coords(Integer.parseInt(args[2]) - 1, Integer | ||
| .parseInt(args[3]) - 1); | ||
| target = new Coords(Integer.parseInt(args[2]) - 1, Integer.parseInt(args[3]) - 1); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
| } | ||
|
|
||
| if (target == null && args.length > 3) { | ||
| target = new Coords(Integer.parseInt(args[2]) - 1, Integer | ||
| .parseInt(args[3]) - 1); | ||
| target = new Coords(Integer.parseInt(args[2]) - 1, Integer.parseInt(args[3]) - 1); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
| ArrayList<Entity> aeros = new ArrayList<>(); | ||
| for (Entity e : entities) { | ||
| if (e.isAero()) { | ||
| ArrayList<Entity> aeroSpaceUnits = new ArrayList<>(); |
Check failure
Code scanning / CodeQL
Container contents are never accessed Error
Updated Dependencies
| return getMountedDisplay(m, loc, null); | ||
| } | ||
|
|
||
| private String getMountedDisplay(Mounted m, int loc, CriticalSlot cs) { | ||
| private String getMountedDisplay(Mounted<?> m, int loc, CriticalSlot cs) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| @@ -207,9 +193,9 @@ | |||
| private Map<Integer, Integer> countBays(Entity entity) { | |||
| Map<Integer, Integer> bayCount = new HashMap<>(); | |||
| for (Bay bay : entity.getTransportBays()) { | |||
| if (bay instanceof MechBay) { | |||
| if (bay instanceof MekBay) { | |||
Check notice
Code scanning / CodeQL
Chain of 'instanceof' tests Note
ProtoMek naming
All classes under src/bot updated with correct copyrights and all Mech -> Mek conversions. Compiles and passes tests.