Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weapon attack cleanup #5922

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Commits on Aug 18, 2024

  1. refactor: Add function for streaming bay weapons

    WeaponMounted.getBayWeapons() iterates through the entire bay before
    returning, which isn't always necessary. It has been refactored to allow
    for the stream to be used directly.
    Saklad5 committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    175a3f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2db8795 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    be1cec7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    29643a5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    34ecf28 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. refactor: Compact Naval C3 firing solution check

    Another contributor pointed out that networkFiringSolution wasn't
    actually necessary, since it was checked immediately and then never
    again.
    Saklad5 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    80404a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. refactor: Use stream composition for adding up bay heat

    The relevant code has been heavily restructured to eliminate unnecessary
    calculations and memory allocation.
    
    In the process of doing so, it became apparent that MegaMek is not
    implementing the penalties of firing an overheating arc as mandated by
    Total Warfare. A comment to that effect has been added.
    Saklad5 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d3c98a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    76b4441 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ca0bbd2 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Configuration menu
    Copy the full SHA
    c2827f9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d061789 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    564eb35 View commit details
    Browse the repository at this point in the history
  4. refactor: Use stream composition for firing BA tasers/Narcs

    This section of code specifically checks whether a BA squad has already
    fired a taser or Narc at a different target.
    Saklad5 committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    c59a753 View commit details
    Browse the repository at this point in the history
  5. refactor: Use stream composition for firing field guns

    It may be possible to optimize this further if it can be assumed that
    all CI attacks either have the infantry flag or are field guns, but I've
    settled for replicating the previous logic for now.
    Saklad5 committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    720a88e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bdfb73b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d16dce5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    891a17d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b21fe79 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    12ed947 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    014cb8f View commit details
    Browse the repository at this point in the history