-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weapon attack cleanup #5922
Open
Saklad5
wants to merge
20
commits into
MegaMek:master
Choose a base branch
from
Saklad5:weapon-attack-cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Weapon attack cleanup #5922
+232
−306
Commits on Aug 18, 2024
-
refactor: Add function for streaming bay weapons
WeaponMounted.getBayWeapons() iterates through the entire bay before returning, which isn't always necessary. It has been refactored to allow for the stream to be used directly.
Configuration menu - View commit details
-
Copy full SHA for 175a3f1 - Browse repository at this point
Copy the full SHA 175a3f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2db8795 - Browse repository at this point
Copy the full SHA 2db8795View commit details -
Configuration menu - View commit details
-
Copy full SHA for be1cec7 - Browse repository at this point
Copy the full SHA be1cec7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29643a5 - Browse repository at this point
Copy the full SHA 29643a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34ecf28 - Browse repository at this point
Copy the full SHA 34ecf28View commit details
Commits on Aug 20, 2024
-
refactor: Compact Naval C3 firing solution check
Another contributor pointed out that networkFiringSolution wasn't actually necessary, since it was checked immediately and then never again.
Configuration menu - View commit details
-
Copy full SHA for 80404a0 - Browse repository at this point
Copy the full SHA 80404a0View commit details
Commits on Aug 21, 2024
-
refactor: Use stream composition for adding up bay heat
The relevant code has been heavily restructured to eliminate unnecessary calculations and memory allocation. In the process of doing so, it became apparent that MegaMek is not implementing the penalties of firing an overheating arc as mandated by Total Warfare. A comment to that effect has been added.
Configuration menu - View commit details
-
Copy full SHA for d3c98a9 - Browse repository at this point
Copy the full SHA d3c98a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76b4441 - Browse repository at this point
Copy the full SHA 76b4441View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca0bbd2 - Browse repository at this point
Copy the full SHA ca0bbd2View commit details
Commits on Aug 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c2827f9 - Browse repository at this point
Copy the full SHA c2827f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d061789 - Browse repository at this point
Copy the full SHA d061789View commit details -
Configuration menu - View commit details
-
Copy full SHA for 564eb35 - Browse repository at this point
Copy the full SHA 564eb35View commit details -
refactor: Use stream composition for firing BA tasers/Narcs
This section of code specifically checks whether a BA squad has already fired a taser or Narc at a different target.
Configuration menu - View commit details
-
Copy full SHA for c59a753 - Browse repository at this point
Copy the full SHA c59a753View commit details -
refactor: Use stream composition for firing field guns
It may be possible to optimize this further if it can be assumed that all CI attacks either have the infantry flag or are field guns, but I've settled for replicating the previous logic for now.
Configuration menu - View commit details
-
Copy full SHA for 720a88e - Browse repository at this point
Copy the full SHA 720a88eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdfb73b - Browse repository at this point
Copy the full SHA bdfb73bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d16dce5 - Browse repository at this point
Copy the full SHA d16dce5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 891a17d - Browse repository at this point
Copy the full SHA 891a17dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b21fe79 - Browse repository at this point
Copy the full SHA b21fe79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12ed947 - Browse repository at this point
Copy the full SHA 12ed947View commit details -
Configuration menu - View commit details
-
Copy full SHA for 014cb8f - Browse repository at this point
Copy the full SHA 014cb8fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.