Allow HTML tags in the TROView fluff #4871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added HTML tag processing to the MechView a few days ago I missed handling the tags in the TRO View. Unfortunately tags get processed (auto-escaped) by the template engine so that they appear as plain text in the result. I did not want to introduce some crazy processing where I replace the tags by some artificial markup or re-engineer the auto-escaped tags. So it was either remove tags entirely before processing (making the tags ineffective in the TRO view) or removing the auto-escaping. I opted for removing the auto-escaping. It seemed to have no negative effects with " and ' characters (see Atlas AS7-D) and I don't expect
<or>to appear in the fluff text which would throw the TRO view off.This PR has no visible effect as long as no HTML tags appear in the fluff.