Fix 4724 old format clan ds gets is ba bay #4726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed an interaction with the old bay format, the format normalizer code, and Clan-tech BA bays.
As of now, a Clan DS in the old format will load, but its BA bay(s) will be converted from Clan tech to IS tech.
The fix is to pass the Clan tech t/f boolean down to the normalizing code. There it will set the Clan bit iff the loaded numbers do not include the new Clan/IS info already.
Tested with the Outpost Clan DS per the report, also other Clan DS models as I could find them.
Added a unit test to verify the correct behavior in this specific case.