Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ATMs and iATMs to share ammunition #4725

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

Saklad5
Copy link
Contributor

@Saklad5 Saklad5 commented Aug 25, 2023

Closes #3701.

This basically uses the same trick that MMLs use, except slightly simpler as all munition types available to both ATMs and iATMs are interchangeable.

ATMs and iATMs can now share ammunition in the same manner as MMLs,
SRMs, and LRMs.
@HammerGS
Copy link
Member

Please remove the history.txt. They are handled by the devs on merge.

Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the changes to tech progression. They are out of the scope of this PR.

@Saklad5
Copy link
Contributor Author

Saklad5 commented Aug 25, 2023

Please remove the changes to tech progression. They are out of the scope of this PR.

Making the ammo equally accessible seems relevant to me. Are you sure?

@HammerGS
Copy link
Member

Please remove the changes to tech progression. They are out of the scope of this PR.

Making the ammo equally accessible seems relevant to me. Are you sure?

Yes. Tech Progression for Ammo needs to match IntOps. We recently addressed the specialty iATM on the rules forum.

I’ll review the TP in a separate review.

@HammerGS HammerGS merged commit 190ce26 into MegaMek:master Oct 2, 2023
4 checks passed
@Saklad5 Saklad5 deleted the atm-ammo branch October 12, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[49.8] iATM Launchers Have Separate iATM Ammo For Standard Ammo Types
2 participants