Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1182 mixed tech ds do not save ba tech type #4709

Merged

Commits on Aug 15, 2023

  1. Fix MML MegaMek#1182: mixed tech Dropship saves BA type

    Initial commit to fix MML issue MegaMek#1182.
    Adds more fields to bay representation in strings and objects;
    normalizes string representations so all bays use the same fields
    in the same ways - no more bay #, _or_ infantry type, _or_ facing
    in one field.
    Sleet01 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    e471e43 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1b14221 View commit details
    Browse the repository at this point in the history
  3. Removed extraneous test file

    Sleet01 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    46a13d4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d943d93 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0abfe64 View commit details
    Browse the repository at this point in the history
  6. Further adding test file

    Added a test file for BLKDropshipFile.java that reads a BLK-file
    string in and confirms new BattleArmor bay behavior.
    Sleet01 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    5312bb9 View commit details
    Browse the repository at this point in the history
  7. Removed some extraneous imports

    I ended up not needing Mockito after all.
    Sleet01 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    3a6ddb8 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Fix warnings found by Git checks

    Add some extra exception handling, fix string equality check,
    make bit-wise operation safer.
    Sleet01 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    355a192 View commit details
    Browse the repository at this point in the history
  2. Fix issue caused by illegal, empty <transporters> blocks.

    It appears that we have been writing empty <transporters> blocks
    into every vehicle for the past 6 or so years.  These blocks should
    not exist in, e.g., combat vehicles, but apparently went unnoticed
    due to loose handling of the relevant block when empty.
    
    This change adds a new test prior to processing these empty blocks
    on file load, a function to support this test, and a conditional
    around writing the <transporters> block to prevent writing empty
    blocks in every .BLK file.
    Sleet01 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    900a5a1 View commit details
    Browse the repository at this point in the history
  3. Remove extraneous call to "exists()"

    New function "containsData" encompasses this call already.
    Sleet01 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    e248132 View commit details
    Browse the repository at this point in the history