New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct issues with nat apt gunnery to hit odds, automatic success me… #4604

Merged

NickAragua merged 1 commit into MegaMek:master from kuronekochomusuke:toHitIssues

Jul 8, 2023

Collaborator

kuronekochomusuke commented Jul 7, 2023

set to hit text box scroll position to top when setting to hit text value
correct issue with natural aptitude gunnery to hit odds display
automatic success to hit message

fixes #4543
fixes #4547


correct issues with nat apt gunnery to hit odds, automatic success me…

d9ebf0a

…ssage, and text box scroll

NickAragua approved these changes

View reviewed changes

megamek/src/megamek/client/ui/swing/FiringDisplay.java

@@ @@ -1974,7 +1974,7 @@ public void updateTarget() { @@
  setFireEnabled(true);
  } else {
  boolean natAptGunnery = ce().hasAbility(OptionsConstants.PILOT_APTITUDE_GUNNERY);
- clientgui.getUnitDisplay().wPan.setToHit(toHit, true);
+ clientgui.getUnitDisplay().wPan.setToHit(toHit, natAptGunnery);

Member

NickAragua Jul 8, 2023

lol

NickAragua merged commit 8be44dd into MegaMek:master

4 checks passed

kuronekochomusuke deleted the toHitIssues branch

July 29, 2023 18:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment