Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.50.01-SNAPSHOT] Aerospace fighter deployment errors in low-altitude maps. #6061

Closed
7 tasks done
Tzahr opened this issue Oct 4, 2024 · 9 comments · Fixed by #6071
Closed
7 tasks done

[0.50.01-SNAPSHOT] Aerospace fighter deployment errors in low-altitude maps. #6061

Tzahr opened this issue Oct 4, 2024 · 9 comments · Fixed by #6071
Assignees

Comments

@Tzahr
Copy link

Tzahr commented Oct 4, 2024

Prerequisites and Pre-Issue Checklist

  • I'm reporting the issue to the correct repository:

  • MegaMek

  • MegaMekLab

  • MekHQ

  • I've tested the issue against at least the latest MILESTONE version

  • I've asked on the MegaMek Discord about the error

  • I've reviewed the BattleTech rules and MegaMek documentation, and I've confirmed that something isn't working as intended.

  • I've searched the Github tracker and haven't found the issue listed

Severity *

High (Major Disruption): A major feature is broken or incorrect, but a workaround exists.

Brief Description *

When deploying Aerospace Fighters in Low Altitude maps, one of the options for altitude deployments it to deploy grounded. This is causing two strange effects to occur:

  • Aerospace fighters cannot deploy over tiles they cannot enter when grounded, even if their altitude is above 0. This is very noticeable when the deployment zone covers trees or foliage.
  • Princess-controlled ASF can deploy grounded. When this occurs, Princess will stall indefinitely during the movement phase. This is current occuring in the attached quicksave.

This is likely related to the DropShip issues mentioned in #6060.

Steps to Reproduce

No response

Operating System *

Windows 11

Java Version *

21.0.3

MegaMek Suite Version *

None

Custom MegaMek Version

Nightly v0.50.1-SNAPSHOT - Rev. a53044e

Attach Files

megamek.log
quicksave.sav.gz

Final Checklist

  • I've checked to make sure that this issue has not already been filed
  • I'm reporting only one issue in this ticket for clarity and focus
@SJuliez SJuliez self-assigned this Oct 4, 2024
@SJuliez
Copy link
Member

SJuliez commented Oct 4, 2024

I am trying to reproduce this. On a low altitude map, I do not seem to get the option to deploy grounded, see screen. Also, I can deploy in hexes that the unit couldnt land in, although the marked hexes suggest otherwise (this is indeed a GUI issue, but it does not seem to be what you're describing).
Also, in the last screen note that this is really a low altitude map and not a ground map.

image
image

@SJuliez
Copy link
Member

SJuliez commented Oct 4, 2024

forgot to add the last screen
image

@Tzahr
Copy link
Author

Tzahr commented Oct 4, 2024

I absolutely enountered a grounded WoB fighter that seemed to have deployed at altitude 0, but through fumbling with tracking down another bug, I've lost the quicksave of it occuring, and now cannot replicate it either even on the same MekHQ scenario that caused it to happen.
I am fairly sure I had the oppertunity to deploy at altitude: 0 for that one as well, but there's a degree of doubt there.

I'm kicking myself for not more diligently documenting it.
I'll append if I encounter it again.

@Tzahr
Copy link
Author

Tzahr commented Oct 4, 2024

Actually - no, I just realised I did attach a quicksave to the report. It includes the grounded WoB fighter with altitude 0 on a low-altitude map.
I just can't replicate it again.

EDIT:
Altitude 0 non-crashed Gotha:
image
Low-alt. proof:
image

@SJuliez
Copy link
Member

SJuliez commented Oct 4, 2024

OK and the Gotha was player-deployed?

@Tzahr
Copy link
Author

Tzahr commented Oct 4, 2024

No, princess-deployed.

@Thom293
Copy link
Contributor

Thom293 commented Oct 5, 2024

I too have seen this and posted a screenshot and save in the QA channel 2 days ago. It was my units but conteolled by princess.

SJuliez added a commit that referenced this issue Oct 7, 2024
#6061: Restore Altitude Behavior for Princess Deploying Aero
@Tzahr
Copy link
Author

Tzahr commented Oct 8, 2024

Unfortunately, I had Princess deploy another altitutde 0 Cheetah during a Low-Athmosphere mission in a Nightly that includes the merge.
Rev. 693da04

image
quicksave.sav.gz
megamek.log

@HammerGS HammerGS reopened this Oct 8, 2024
@SJuliez
Copy link
Member

SJuliez commented Oct 9, 2024

I have another fix for that, #6080
The problem is probably the negative hex levels. I am still not sure why Princess would deploy at alt 0 though as she should respect the altitude set in the lobby which is normally 5. Unless this was changed or other values came from MHQ. I'll leave this open for further reports, for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants