-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reference image tests for untested plots/blocks #4433
Merged
Merged
Changes from 22 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
12949fe
add test for boxplot
ffreyer 41c5acf
add test for crossbar
ffreyer ea73679
add qqnorm and qqplot
ffreyer cdabe99
add ecdfplot
ffreyer ac7bda0
add rainclouds
ffreyer c4fdbc4
add series
ffreyer 657445f
add stairs
ffreyer 6bcfabe
add stem
ffreyer f57e8cc
add waterfall
ffreyer abd06a9
add test for Button, Slider, Toggle, IntervalSlider
ffreyer 4abca78
add test for ablines, h/vlines and h/vspan
ffreyer 9a25178
add another violin test
ffreyer ba97237
add volumeslices test
ffreyer 620bcc7
extend test with Textbox
ffreyer 70a8727
Merge branch 'master' into ff/missing-refimages
ffreyer 5e439ab
fix test name
ffreyer 4c955b6
Merge branch 'ff/missing-refimages' of https://github.com/MakieOrg/Ma…
ffreyer a29ede1
Merge branch 'master' into ff/missing-refimages
ffreyer 732537d
fix bad block
ffreyer ed79f4f
Merge branch 'master' into ff/missing-refimages
ffreyer a433874
Merge branch 'master' into ff/missing-refimages
ffreyer 54fe949
Merge branch 'ff/missing-refimages' of https://github.com/MakieOrg/Ma…
ffreyer 5f6b1cd
fix name conflicts with Bonito
ffreyer f3f762c
reduce symmetry
ffreyer 966efc3
Merge branch 'master' into ff/missing-refimages
ffreyer 8561447
Merge branch 'master' into ff/missing-refimages
ffreyer d6b623f
Merge branch 'master' into ff/missing-refimages
ffreyer ad90ce2
stabilize test
ffreyer 782e482
Merge branch 'master' into ff/missing-refimages
ffreyer 15b8ce1
fix module
ffreyer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -324,4 +324,4 @@ end | |
# f.scene.events.scroll[] = (0, -10) | ||
# # reference test the zoomed out plot | ||
# f | ||
# end | ||
# end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually stopped doing reference tests where there's some kind of symmetry in the data. Like here, all groups have the same data basically, so if there was something wrong in the mapping from categories to groups, you wouldn't see it here. Instead I'd add the group values to the data maybe, so you'd see three shifted violins, or something to that effect.