-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reference image tests for untested plots/blocks #4433
Conversation
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
|
…kie.jl into ff/missing-refimages
Is there any documentation about updating/creating ref image tests? Is the image pre-generated and uploaded or do you use some relative score between ref images dynamically generated during test time? |
#4108 added some notes to prs about it. @reference_test "some name" begin
# your code...
fig
end block, like in this pr. CI produces an image for each of these blocks and compares it to a reference image if it exists. When a new reference test is added (or if one gets changed) the maintainers need to upload the new image. |
…kie.jl into ff/missing-refimages
|
||
categories = RNG.rand(1:3, 1000) | ||
values = RNG.randn(1000) | ||
violin(fig[1, 1], categories, values) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually stopped doing reference tests where there's some kind of symmetry in the data. Like here, all groups have the same data basically, so if there was something wrong in the mapping from categories to groups, you wouldn't see it here. Instead I'd add the group values to the data maybe, so you'd see three shifted violins, or something to that effect.
Description
Plots/Blocks that do not have (direct) reference images:
timeseries(unlikely to be consistent in refimage tests due to dependency on sleep/time)LineSegmentBuffer, TextBuffertested via axis3d!, considered internal, may disappear in the futurePlots that may need more:
spyalready has test testing multiple configurationsType of change