-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Southern Hemisphere region #205
Conversation
@xylar Can you take a look at this and let me know if you see any issues? I'm having issues using it with MPAS-Analysis but I think something might be off with my editable environment because when I use a modified pytest to check these features they seem fine. |
@cbegeman, yes, it looks fine to me. |
@xylar Would you be willing to give this a try in MPAS-Analysis? I was changing the |
@cbegeman, sure, I can give it a try tomorrow. |
@cbegeman, I see the problem. We could presumably write a post-processed version of OHC that could take a region from a mask but that doesn't yet exist. Or alternatively wouldn't OHC be trivial to calculate from mean temperature in a region (using |
@xylar: you are not missing anything. I always thought that OHC analysis tasks could be done in post-process mode (along with regional statistics, to be honest). In fact, I believe that the other OHC task, the climatological maps, is done using the layer-weighted averaged temperature. |
Thanks @xylar and @milenaveneziani. It seems like post-processing OHC makes a lot of sense and could allow the AM to be removed in OMEGA. I'll implement it in MPAS-Analysis. This work was motivated by being able to compare our SORRM OHC with published values from CMIP6 models. |
'date': '20200621', | ||
'date': '20240830', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbegeman, I updated the date stamp for Ocean Basins. I hope you don't mind.
This is needed so new region masks get created in MPAS-Analysis and Compass that include Southern Hemisphere.
@xylar Does this look ready for review to you? Seems like you successfully used it in your MPAS-A PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and, yes, I was able to test it in MPAS-Analysis. It successfully produced ocean heat content integrated over the region:
MPAS-Dev/MPAS-Analysis#1034 (comment)
@cbegeman, remind me that we'll want to cache some mask files for typical meshes with these new regions to save MPAS-Analysis from generating them every time it runs. This would be once this is being used in MPAS-Analysis, of course. |
Thanks @xylar for your testing. I'll merge now. |
@xylar Actually, I don't have permissions to merge so you'll have to do it. |
@cbegeman, for the future, I added you as a maintainer. But happy to merge this. |
@xylar Thanks! |
Add a region for the Southern Hemisphere