Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OHC anomaly to timeSeriesOceanRegions #1034

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Add OHC anomaly to timeSeriesOceanRegions #1034

wants to merge 5 commits into from

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Nov 4, 2024 •
edited
Loading

Checklist

  • User's Guide has been updated
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes

@xylar
Copy link
Collaborator Author

xylar commented Nov 4, 2024 •
edited
Loading

An example result from the test suite:
image

I will request reviews as soon as I have run this on a SORRM v2.1 simulation (with the southern hemisphere geometric feature MPAS-Dev/geometric_features#205 included).

@xylar
Copy link
Collaborator Author

xylar commented Nov 4, 2024

I just noticed some glitches in the figure above. I think I've fixed them an will replace it if so.

@xylar
Copy link
Collaborator Author

xylar commented Nov 4, 2024

Somewhat better but the title is still a mess.

@xylar
Copy link
Collaborator Author

xylar commented Nov 4, 2024

Here's the SORRM v2.1 ensemble mean analysis over the historical:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis/southern_hemisphere_ohc/v2_1.SORRM.historical_ensmean/ocean/index.html
Here's the Southern Hemisphere:
image

@xylar
Copy link
Collaborator Author

xylar commented Nov 4, 2024

@cbegeman and @darincomeau,

For the v2.1 paper, several details and associated questions:

  • This a curve over a single range of depths (0 to 10,000 m shown here). We can run the analysis multiple times to analyze/plot different depth ranges. Is that sufficient for our needs?
  • I am computing anomalies here from January of the reference year, and only for plotting purposes. The NetCDF files just have the OHC time series (not anomalies). Does that seem okay for our needs?
  • I don't currently have a way to support (for plotting purposes) an anomaly reference year that isn't somewhere in the time series. MPAS-Analysis already isn't good at having an anomaly year from a different simulation. This means MPAS-Analysis isn't capable of computing the OHC anomaly during the SSP with respect to, say, 1950. I believe this is okay for our purposes but let me know.
  • My thought is that we stitch together whichever OHC netcdf output we want to use in a separate analysis script, compute the anomaly and maybe a running mean, and fit a trend line. Does that sound right?

@xylar xylar mentioned this pull request Nov 5, 2024
Merged
@xylar
Copy link
Collaborator Author

xylar commented Nov 5, 2024

I won't merge this until we get MPAS-Dev/geometric_features#205 merge, do a release of geometric_features, and update the constraint on geometric_features here.

@xylar
Simplify variables for time series ocean regions
8afb5fe 
Rather than defining the full list of dictionaries for each
region, define one list of dict of available variables and then
just a list of variables for each region.
@xylar
Add OHC anomaly to timeSeriesOceanRegions
5933cc6
@xylar
Allow for longer titles
ae6d290 
The region name is getting completely cut off in some cases.
@xylar
Add OHC plots in Ocean Basins
4fe1028
@xylar
Update docs
8f607dd
@xylar xylar requested a review from cbegeman November 13, 2024 17:43
@xylar xylar self-assigned this Nov 13, 2024
cbegeman
cbegeman reviewed Nov 14, 2024
View reviewed changes
docs/users_guide/tasks/timeSeriesOceanRegions.rst
The ``anomalies`` list are the variables from ``variables`` that should be
plotted as anomalies from the beginning of the simulation or from
``anomalyRefYear`` for time series if that config option is defined.
By default, this is applied ot the ocean heat content in cases where it is
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By default, this is applied ot the ocean heat content in cases where it is
By default, this is applied to the ocean heat content in cases where it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbegeman cbegeman cbegeman left review comments

Assignees

@xylar xylar

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xylar @cbegeman