Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ice thickness and pressure where above flotation #855

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Aug 28, 2024

We don't want ice thickness and pressure to exceed their flotation
values. Previously, we were only making sure that ice draft did
not exceed its flotation value (i.e. the draft was above the bed).

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added bug Something isn't working ocean labels Aug 28, 2024
@xylar xylar self-assigned this Aug 28, 2024
We don't want ice thickness and pressure to exceed their flotation
values.  Previously, we were only making sure that ice draft did
not exceed its flotation value (i.e. the draft was above the bed).
@xylar
Copy link
Collaborator Author

xylar commented Aug 29, 2024

Testing

Tested with #854 and #807, see #854 (comment)

@xylar xylar merged commit 4203ebc into MPAS-Dev:main Aug 29, 2024
4 checks passed
@xylar xylar deleted the fix-draft-deeper-than-bathy branch August 29, 2024 13:23
@xylar xylar mentioned this pull request Aug 29, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant