Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix masking of ice draft and ice thickness in combine_topo #854

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Fix masking of ice draft and ice thickness in combine_topo #854

merged 2 commits into from
Aug 29, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Aug 28, 2024 •
edited
Loading

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added bug Something isn't working ocean labels Aug 28, 2024
@xylar xylar self-assigned this Aug 28, 2024
@xylar
Copy link
Collaborator Author

xylar commented Aug 29, 2024

Testing

I ran this along with #855 and #807, and now see sensible masking of ice thickness (which is also bounded to be below the flotation thickness because of #855):

limited_thickness

@xylar xylar merged commit a0e3eee into MPAS-Dev:main Aug 29, 2024
4 checks passed
@xylar xylar deleted the fix-combine-topo-masking branch August 29, 2024 13:22
This was referenced Aug 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
bug Something isn't working ocean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xylar