Revamped seat placement in cabin #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 76.41% 78.26% +1.85%
==========================================
Files 69 71 +2
Lines 13169 13418 +249
==========================================
+ Hits 10063 10502 +439
+ Misses 3106 2916 -190 ☔ View full report in Codecov by Sentry. |
more seating options + five abreast changed 9 seat option to 3-3-3 fixed bug in seats per row calculation updated fun descrs considered case when Dfuse = Dmin replaced equality with approx updated seat placement options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revisits the old functions to place seats, originally developed for output visualization only. The old functions could only handle symmetric seating or asymmetric seating of 3 or 5 passengers.
The new functions use a dictionary with the seating layout precomputed for up to 16 passengers per row. By selecting the maximum number of seats per row possible for a given fuselage radius, this can also be used to resize the fuselage diameter in smaller steps than before. The old distinction between symmetric and asymmetric layouts has been removed as the code is agnostic to it.
This PR also addresses issue #27 by introducing a floor separation parameter in the cases when the aircraft is a double decker. The two floors are assumed to be distributed symmetrically inside the cross section, which can be a double bubble.