-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update theme and intersphinx #127
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #127 +/- ##
=======================================
Coverage 87.55% 87.55%
=======================================
Files 5 5
Lines 747 747
Branches 127 127
=======================================
Hits 654 654
Misses 56 56
Partials 37 37 ☔ View full report in Codecov by Sentry. |
u'Irfan Alibay,Zhiyi Wu') | ||
copyright = u'2007-2021, ' + authors | ||
project = "GridDataFormats" | ||
authors = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should really use an author file...
Co-authored-by: Irfan Alibay <[email protected]>
Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-10-21 20:01:06 UTC |
Co-authored-by: Irfan Alibay <[email protected]>
I'll have a look if I can get it to work as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orbeckst I think this will now pick up the wrong yaml file
Locally I can't get the sphinx stuff to install in a Python 3.12 environment:
so need to do sphinx in 3.10 or so. |
ok, need to pip-install sphinx_sitemap — somehow I had hoped that this was magically included in mdanalysis-sphinx-theme (but on reflection it's sensible that it isn't).
|
Thank you @lilyminium and also thanks @IAlibay ! |
No description provided.