Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 1.0.2 #129

Closed
6 tasks done
orbeckst opened this issue Oct 21, 2023 · 7 comments
Closed
6 tasks done

release 1.0.2 #129

orbeckst opened this issue Oct 21, 2023 · 7 comments
Assignees
Labels

Comments

@orbeckst
Copy link
Member

orbeckst commented Oct 21, 2023

WIth #124 fixed and Py 3.12 supported/tested, I'll cut a quick 1.0.2 release.

@orbeckst orbeckst self-assigned this Oct 21, 2023
@IAlibay
Copy link
Member

IAlibay commented Oct 21, 2023

@orbeckst could you merge #126 first so we can use the new deployment action?

@orbeckst
Copy link
Member Author

sure!

@orbeckst
Copy link
Member Author

orbeckst commented Oct 21, 2023

@orbeckst orbeckst mentioned this issue Oct 21, 2023
@orbeckst
Copy link
Member Author

orbeckst commented Oct 21, 2023

✅ 1.0.2 deployed to pypi https://pypi.org/project/GridDataFormats/1.0.2/
✅ I tested locally in macOS 3.10 and 3.12 (pip install GridDataFormats==1.0.2) and all tests pass.

However, the deployment workflow tested the old 1.0.1 https://github.com/MDAnalysis/GridDataFormats/actions/runs/6599833488/job/17929267034#step:5:384

Run # sleep for 10 seconds to make sure things are refreshing upstream
  ...
  # Install via pipx and run tests
  python -m pip install ${PIP_URLS} GridDataFormats
  python -m pip install pytest
  ...
 Collecting GridDataFormats
  Downloading GridDataFormats-1.0.1-py3-none-any.whl (2.1 MB)
  ...

I would have expected the workflow to pick up and test the uploaded version, 1.0.2. Maybe the 10s delay wasn't enough?

@orbeckst
Copy link
Member Author

All done here.

@IAlibay when you have time, maybe look at the part of the new deployment workflow that pulls down the latest version from PyPi and tests it (see comment above) as it does not seem to be guaranteed to be testing the release just uploaded.

@IAlibay
Copy link
Member

IAlibay commented Oct 22, 2023

All done here.

@IAlibay when you have time, maybe look at the part of the new deployment workflow that pulls down the latest version from PyPi and tests it (see comment above) as it does not seem to be guaranteed to be testing the release just uploaded.

You mean the testpypi bit? Did it not pull down the right version? It's hard to enforce a version match (because we aren't pulling down tags), but I can see what we can do

@IAlibay
Copy link
Member

IAlibay commented Oct 22, 2023

Just saw your above message - I feel like GitHub isn't sending me all the emails right now..

I'll see if we can do a time check at the very least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants