Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update editor-command to 1.0.0 #434

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Dec 27, 2024

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

This replaces shellish_parse with shell-words, which was already in our dep tree so this eliminates one dep at least.

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

It's possible there are some differences between the two that break stuff for users. The tests on editor-command are pretty good though so I'm not too worried.

QA

How did you test this?

Relying on editor-command tests

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

This replaces shellish_parse with shell-words, which was already in our dep tree so this eliminates one dep at least.
@LucasPickering LucasPickering enabled auto-merge (rebase) December 27, 2024 20:54
@LucasPickering LucasPickering merged commit 41498fa into master Dec 27, 2024
15 checks passed
@LucasPickering LucasPickering deleted the update-editor-command branch December 27, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant