Skip to content

Commit

Permalink
Update editor-command to 1.0.0
Browse files Browse the repository at this point in the history
This replaces shellish_parse with shell-words, which was already in our dep tree so this eliminates one dep at least.
  • Loading branch information
LucasPickering committed Dec 27, 2024
1 parent 54cc76e commit 5eb769e
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 15 deletions.
11 changes: 8 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,19 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),

## [Unreleased] - ReleaseDate

### Changed

- Update [editor-command](https://crates.io/crates/editor-command), which replaces [shellish_parse](https://crates.io/crates/shellish_parse) with [shell-words](https://crates.io/crates/shell-words) for editor and pager command parsing
- There should be no impact to users

## [2.4.0] - 2024-12-27

### Added

- Add filter box to the recipe list
- This behavior is not necessarily final. Please leave feedback if you think it could be improved.

### Changes
### Changed

- Wrap long error messages in response pane
- Include data path in config/collection deserialization errors
Expand All @@ -38,7 +43,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
- Add "View Body" action to response bodies, to open a body in an external viewer such as `less` or `fx` [#404](https://github.com/LucasPickering/slumber/issues/404)
- By default `less` is used. You can customize this with the [`viewer` config field](https://slumber.lucaspickering.me/book/api/configuration/editor.html)

### Changes
### Changed

- Preserve key order of objects in JSON responses [#405](https://github.com/LucasPickering/slumber/issues/405)

Expand Down Expand Up @@ -204,7 +209,7 @@ This release focuses on minor fixes and improvements. There are no new major fea

- Add global `--log` argument to CLI, to print the log file being used for that invocation

### Changes
### Changed

- Checkbox row state and folder expand/collapse state are now toggled via the spacebar instead of enter
- Enter now sends a request from anywhere. While this change may be annoying, it will hopefully be more intuitive in the long run.
Expand Down
12 changes: 3 additions & 9 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/tui/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ chrono = {workspace = true}
cli-clipboard = "0.4.0"
crossterm = {workspace = true, features = ["bracketed-paste", "windows", "events", "event-stream"]}
derive_more = {workspace = true, features = ["debug", "deref", "deref_mut", "display", "from"]}
editor-command = "0.1.0"
editor-command = "1.0.0"
futures = {workspace = true}
indexmap = {workspace = true}
itertools = {workspace = true}
Expand Down
4 changes: 2 additions & 2 deletions docs/src/api/configuration/editor.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Slumber supports passing additional arguments to the editor. For example, if you
editor: code --wait
```
The command will be parsed like a shell command (although a shell is never actually invoked). For exact details on parsing behavior, see [shellish_parse](https://docs.rs/shellish_parse/latest/shellish_parse/index.html).
The command will be parsed like a shell command (although a shell is never actually invoked). For exact details on parsing behavior, see [shell-words](https://docs.rs/shell-words/1.1.0/shell_words/fn.split.html).
## Paging
Expand All @@ -27,7 +27,7 @@ You can open your response bodies in a separate file browser if you want additio
pager: bat
```

> The pager command uses the same format as the `editor` field. The command is parsed with [shellish_parse](https://docs.rs/shellish_parse/latest/shellish_parse/index.html), then a temporary file path is passed as the final argument.
> The pager command uses the same format as the `editor` field. The command is parsed with [shell-words](https://docs.rs/shell-words/1.1.0/shell_words/fn.split.html), then a temporary file path is passed as the final argument.

To open a body in the pager, use the actions menu keybinding (`x` by default, see [input bindings](./input_bindings.md)), and select `View Body`.

Expand Down

0 comments on commit 5eb769e

Please sign in to comment.