Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Инспектор #324

Closed
wants to merge 2 commits into from
+194 −177
Closed

Инспектор #324

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b80f2db
Инспектор
Nov 7, 2024
8dd730a
Speed fix CanBeAntag ispector
Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Content.Shared/Access/Components/IdCardConsoleComponent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public WriteToTargetIdMessage(string fullName, string jobTitle, List<ProtoId<Acc
"Zookeeper", // DeltaV - Add Zookeeper access
"ChiefJustice", // DeltaV - Add Chief Justice access
"Justice", // DeltaV - Add Justice access
"Prosecutor", // Delta V - Add Prosecutor access
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prosecutor на Inspector обратно изменить, комментарий тоже восстановить

"Inspector", // LPP - Add inspector access
"EVA", // lpp
"Gateway", // lpp
"LPPExpeditor", // lpp
Comment on lines +94 to 97
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Рекомендуется унифицировать стиль комментариев

Для поддержания единообразия кодовой базы предлагается привести комментарии к общему стилю:

-        "Inspector", // LPP - Add inspector access
-        "EVA", // lpp
-        "Gateway", // lpp
-        "LPPExpeditor", // lpp
+        "Inspector",  // LPP: Add Inspector access
+        "EVA",       // LPP: External access
+        "Gateway",   // LPP: Gateway access
+        "LPPExpeditor",  // LPP: Expeditor access
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"Inspector", // LPP - Add inspector access
"EVA", // lpp
"Gateway", // lpp
"LPPExpeditor", // lpp
"Inspector", // LPP: Add Inspector access
"EVA", // LPP: External access
"Gateway", // LPP: Gateway access
"LPPExpeditor", // LPP: Expeditor access

💡 Codebase verification

Обнаружены остаточные упоминания роли Прокурора

В системе все еще присутствуют файлы, содержащие упоминания роли Прокурора, которые необходимо обновить:

  • Resources/Prototypes/DeltaV/StatusEffects/job.yml
  • Resources/Prototypes/DeltaV/Entities/Objects/Devices/pda.yml
  • Resources/Prototypes/DeltaV/Entities/Markers/Spawners/jobs.yml
  • Resources/Prototypes/DeltaV/Entities/Clothing/Uniforms/jumpsuits.yml
  • Resources/Prototypes/DeltaV/Entities/Clothing/Uniforms/jumpskirts.yml
  • Resources/Prototypes/DeltaV/Entities/Clothing/Neck/misc.yml

Необходимо заменить все упоминания "Prosecutor" на "Inspector" в указанных файлах для обеспечения согласованности изменений.

🔗 Analysis chain

Необходимо проверить полное удаление доступа Прокурора

Хотя доступ Инспектора был добавлен корректно, важно убедиться, что все упоминания роли Прокурора были полностью удалены из системы.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Описание: Поиск оставшихся упоминаний роли Прокурора
echo "Поиск упоминаний 'Prosecutor' в коде:"
rg -i "prosecutor"

Length of output: 2031

Script:

#!/bin/bash
# Проверим, есть ли упоминания в файлах конфигурации доступа и ролей
echo "Поиск упоминаний в файлах конфигурации доступа:"
rg -i "prosecutor" -g "*.yml" --type yaml -A 5 Resources/Prototypes/**/access.yml Resources/Prototypes/**/jobs.yml

echo -e "\nПроверка файлов с ID-картами и правами доступа:"
rg -i "prosecutor" -g "*.cs" --type csharp Content.Shared/Access/

Length of output: 548

Script:

#!/bin/bash
# Поиск файлов конфигурации в правильных директориях
echo "Поиск файлов конфигурации доступа и ролей:"
fd -e yml -e yaml

echo -e "\nПроверка содержимого найденных файлов на наличие 'prosecutor':"
fd -e yml -e yaml -x rg -i "prosecutor" -l {} \;

echo -e "\nПроиск определений ролей и прав доступа в коде:"
ast-grep --pattern 'enum $_Access {
  $$$
}'

Length of output: 196096

Expand Down
2 changes: 1 addition & 1 deletion Resources/Locale/en-US/deltav/job/job-description.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
job-description-medical-borg = Half-human, Half-machine. Follow your laws, serve the crew, and assist the medical department.
job-description-chief-justice = Manage the justice department, act as a judge, and ensure everyone recieves fair and just treatment.
job-description-clerk = Organize trials, notarize documents, review charges, and act as a judge if needed.
job-description-prosecutor = Take statements from security and prepare cases against those accused of commiting crimes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prosecutor вернуть вместо inspector

job-description-inspector = Take statements from security and prepare cases against those accused of commiting crimes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Исправьте опечатку в описании должности.

В описании должности инспектора есть опечатка: "commiting" должно быть "committing".

Примените следующие изменения:

-job-description-inspector = Take statements from security and prepare cases against those accused of commiting crimes.
+job-description-inspector = Take statements from security and prepare cases against those accused of committing crimes.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
job-description-inspector = Take statements from security and prepare cases against those accused of commiting crimes.
job-description-inspector = Take statements from security and prepare cases against those accused of committing crimes.

💡 Codebase verification

Обнаружены несогласованные названия роли в файлах прототипов

В кодовой базе найдены файлы, где все еще используется старое название "prosecutor":

  • Resources/Prototypes/DeltaV/StatusEffects/job.yml (иконки и состояния)
  • Resources/Prototypes/DeltaV/Entities/Objects/Devices/pda.yml (состояния PDA)
  • Resources/Prototypes/DeltaV/Entities/Markers/Spawners/jobs.yml (состояние спавнера)
  • Спрайты униформы и значка все еще используют префикс "prosecutor" в путях:
    • DeltaV/Clothing/Uniforms/Jumpsuit/prosecutorred.rsi
    • DeltaV/Clothing/Uniforms/Jumpskirt/prosecutorred.rsi
    • DeltaV/Clothing/Neck/Misc/prosecutorbadge.rsi

Необходимо обновить эти файлы, чтобы они соответствовали новому названию роли "Inspector".

🔗 Analysis chain

Проверьте согласованность названия роли во всех файлах.

Убедитесь, что замена "Prosecutor" на "Inspector" выполнена последовательно во всех связанных файлах.

Выполните следующий скрипт для проверки:

Let me check if there are corresponding new "inspector" files and references to match the renamed role, as we found several "prosecutor" references in prototypes and sprite paths.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Описание: Поиск оставшихся упоминаний "prosecutor" в кодовой базе

echo "Поиск упоминаний 'prosecutor' в файлах локализации:"
rg -i "prosecutor" "Resources/Locale"

echo -e "\nПоиск упоминаний 'prosecutor' в файлах прототипов:"
rg -i "prosecutor" "Resources/Prototypes"

echo -e "\nПоиск упоминаний 'prosecutor' в других файлах:"
rg -i "prosecutor" --type-not yaml --type-not ftl

Length of output: 1710

Script:

#!/bin/bash
# Поиск файлов с упоминанием "inspector" для сравнения
echo "Поиск упоминаний 'inspector' в файлах прототипов:"
rg -i "inspector" "Resources/Prototypes"

echo -e "\nПроверка наличия соответствующих файлов с 'inspector' в спрайтах:"
fd "inspector.*\.rsi$" Resources/Textures

Length of output: 10233

job-description-courier = Deliver mail and other packages from and to logistics. Avoid dogs.
2 changes: 1 addition & 1 deletion Resources/Locale/en-US/deltav/job/job-names.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
job-name-medical-borg = Medical Cyborg
job-name-chief-justice = Chief Justice
job-name-clerk = Clerk
job-name-prosecutor = Prosecutor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в job-name- меняй обратно на prosecutor

job-name-inspector = inspector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Необходимо использовать заглавную букву для названия должности.

Для соблюдения единого стиля с другими названиями должностей в файле, значение должно начинаться с заглавной буквы.

Примените следующие изменения:

-job-name-inspector = inspector
+job-name-inspector = Inspector
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
job-name-inspector = inspector
job-name-inspector = Inspector

job-name-lawyer = Attorney
job-name-courier = Courier
2 changes: 1 addition & 1 deletion Resources/Locale/en-US/deltav/navmap-beacons/station-beacons.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ station-beacon-corpsman = Corpsman

station-beacon-justice = Justice
station-beacon-chiefjustice = Chief Justice
station-beacon-prosecutor = Prosecutor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Меняй в station-beacon- обратно на prosecutor

station-beacon-inspector = inspector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Необходимо исправить регистр значения маяка станции.

Значение маяка inspector должно начинаться с заглавной буквы, как и все остальные значения маяков в файле.

Примените следующие изменения:

-station-beacon-inspector = inspector
+station-beacon-inspector = Inspector
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
station-beacon-inspector = inspector
station-beacon-inspector = Inspector

2 changes: 1 addition & 1 deletion Resources/Locale/en-US/deltav/prototypes/access/accesses.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
id-card-access-level-orders = Orders
id-card-access-level-mantis = Mantis
id-card-access-level-cj = Chief Justice
id-card-access-level-prosecutor = Prosecutor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в id-card-access-level- меняй обратно на prosecutor

id-card-access-level-inspector = Inspector
id-card-access-level-justice = Justice
id-card-access-level-corpsman = Corpsman
4 changes: 2 additions & 2 deletions Resources/Locale/en-US/ss14-ru/prototypes/deltav/entities/clothing/neck/misc.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
ent-ClothingNeckProsecutorbadge = prosecutor badge
.desc = A badge to show that the owner is a 'legitimate' prosecutor who passed the NT bar exam required to practice law.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вернуть айди ClothingNeckProsecutorbadge

ent-ClothingNeckPinspectorbadge = inspector badge
.desc = A badge to show that the owner is a 'legitimate' inspector who passed the NT bar exam required to practice law.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Исправьте написание и идентификатор записи.

В соответствии с правилами локализации:

  1. После знака "=" первое слово должно начинаться с заглавной буквы для записей, начинающихся с "ent-"
  2. В идентификаторе сущности присутствует опечатка: "Pinspector" вместо "Inspector"

Предлагаемые изменения:

-ent-ClothingNeckPinspectorbadge = inspector badge
+ent-ClothingNeckInspectorbadge = Inspector badge
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-ClothingNeckPinspectorbadge = inspector badge
ent-ClothingNeckInspectorbadge = Inspector badge

4 changes: 2 additions & 2 deletions Resources/Locale/en-US/ss14-ru/prototypes/deltav/entities/clothing/uniforms/jumpskirts.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ ent-ClothingUniformJumpskirtChiefJustice = chief justice's jumpskirt
.desc = A fancy black jumpskirt with a lace cravat to make it even more fancy. Proper judicial attire.
ent-ClothingUniformJumpskirtClerk = clerk's dress skirt
.desc = A modest dress skirt for the person with the power to notarize anything.
ent-ClothingUniformJumpskirtProsecutor = prosecutor's dress skirt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вернуть айди ClothingUniformJumpskirtProsecutor

.desc = A red suit and skirt with a fancy cravat. Perfect for a prosecutor.
ent-ClothingUniformJumpskirtInspector = inspector's dress skirt
.desc = A red suit and skirt with a fancy cravat. Perfect for a inspector.
Comment on lines +21 to +22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Рассмотрите возможность уточнения описания

Текущее описание довольно общее и унаследовано от роли прокурора. Предлагаю адаптировать его более конкретно под роль инспектора.

Предлагаемые изменения:

-    .desc = A red suit and skirt with a fancy cravat. Perfect for a inspector.
+    .desc = A red suit and skirt with a fancy cravat. The distinguished attire of a station inspector.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-ClothingUniformJumpskirtInspector = inspector's dress skirt
.desc = A red suit and skirt with a fancy cravat. Perfect for a inspector.
ent-ClothingUniformJumpskirtInspector = inspector's dress skirt
.desc = A red suit and skirt with a fancy cravat. The distinguished attire of a station inspector.

⚠️ Potential issue

Исправьте заглавную букву после знака равенства

Согласно правилам кодирования, все переводы, начинающиеся с "ent-", должны иметь заглавную букву после знака равенства.

Примените следующие изменения:

-ent-ClothingUniformJumpskirtInspector = inspector's dress skirt
+ent-ClothingUniformJumpskirtInspector = Inspector's dress skirt
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-ClothingUniformJumpskirtInspector = inspector's dress skirt
.desc = A red suit and skirt with a fancy cravat. Perfect for a inspector.
ent-ClothingUniformJumpskirtInspector = Inspector's dress skirt
.desc = A red suit and skirt with a fancy cravat. Perfect for a inspector.

4 changes: 2 additions & 2 deletions Resources/Locale/en-US/ss14-ru/prototypes/deltav/entities/clothing/uniforms/jumpsuits.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,5 @@ ent-ClothingUniformJumpsuitClerk = clerk's suit
.desc = A modest suit for the person with the power to notarize anything.
ent-ClothingUniformJumpsuitChemShirt = formal chemistry suit
.desc = There's still some odd stains on this suit. Hm.
ent-ClothingUniformJumpsuitProsecutor = prosecutor's suit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вернуть айди ClothingUniformJumpsuitProsecutor

.desc = A red suit with a fancy cravat. Perfect for a prosecutor.
ent-ClothingUniformJumpsuitInspector = inspector's suit
.desc = A red suit with a fancy cravat. Perfect for a inspector.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Рекомендуется уточнить описание униформы

В описании есть небольшая грамматическая ошибка: используется неопределенный артикль "a" перед словом "inspector". Также можно сделать описание более информативным.

Предлагаемое исправление:

-    .desc = A red suit with a fancy cravat. Perfect for a inspector.
+    .desc = A red suit with a fancy cravat. Perfect for an inspector of the station.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.desc = A red suit with a fancy cravat. Perfect for a inspector.
.desc = A red suit with a fancy cravat. Perfect for an inspector of the station.

2 changes: 1 addition & 1 deletion Resources/Locale/en-US/ss14-ru/prototypes/deltav/entities/markers/spawners/jobs.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ent-SpawnPointChiefJustice = chiefjustice
.desc = { ent-SpawnPointJobBase.desc }
ent-SpawnPointClerk = clerk
.desc = { ent-SpawnPointJobBase.desc }
ent-SpawnPointProsecutor = prosecutor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вернуть айди обратно на SpawnPointProsecutor

ent-SpawnPointInspector = inspector
.desc = { ent-SpawnPointJobBase.desc }
Comment on lines +7 to 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Необходимо исправить регистр первой буквы значения.

Согласно правилам кодирования, все значения после = для ключей, начинающихся с ent-, должны начинаться с заглавной буквы.

Примените следующие изменения:

-ent-SpawnPointInspector = inspector
+ent-SpawnPointInspector = Inspector
    .desc = { ent-SpawnPointJobBase.desc }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-SpawnPointInspector = inspector
.desc = { ent-SpawnPointJobBase.desc }
ent-SpawnPointInspector = Inspector
.desc = { ent-SpawnPointJobBase.desc }

ent-SpawnPointCourier = courier
.desc = { ent-SpawnPointJobBase.desc }
2 changes: 1 addition & 1 deletion Resources/Locale/en-US/ss14-ru/prototypes/deltav/entities/objects/devices/pda.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ent-ChiefJusticePDA = chief justice PDA
.desc = Whosoever bears this PDA is the law.
ent-ClerkPDA = clerk PDA
.desc = It has the stamp to prove it's been officially notarized!
ent-ProsecutorPDA = prosecutor PDA
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вернуть ProsecutorPDA

ent-InspectorPDA = inspector PDA
.desc = Sharp. Looks like it could prosecute you all on its own.
Comment on lines +7 to 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Обновите описание в соответствии с новой ролью

Текущее описание все еще содержит отсылку к прокурорской деятельности ("prosecute"), что не соответствует новой роли Инспектора. Рекомендуется изменить описание, чтобы оно лучше отражало функции Инспектора.

Предлагаемые изменения:

 ent-InspectorPDA = inspector PDA
-    .desc = Sharp. Looks like it could prosecute you all on its own.
+    .desc = Sharp. Looks like it could inspect every detail on its own.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-InspectorPDA = inspector PDA
.desc = Sharp. Looks like it could prosecute you all on its own.
ent-InspectorPDA = inspector PDA
.desc = Sharp. Looks like it could inspect every detail on its own.

ent-SyndiListeningPostPDA = { ent-SyndiPDA }
.desc = { ent-SyndiPDA.desc }
4 changes: 2 additions & 2 deletions Resources/Locale/en-US/ss14-ru/prototypes/deltav/entities/objects/devices/station_beacon.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,6 @@ ent-DefaultStationBeaconJustice = { ent-DefaultStationBeacon }
ent-DefaultStationBeaconChiefJustice = { ent-DefaultStationBeacon }
.suffix = Chief Justice
.desc = { ent-DefaultStationBeacon.desc }
ent-DefaultStationBeaconProsecutor = { ent-DefaultStationBeacon }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вернуть DefaultStationBeaconProsecutor

.suffix = Prosecutor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вернуть суффикс Prosecutor

ent-DefaultStationBeaconInspector = { ent-DefaultStationBeacon }
.suffix = inspector
.desc = { ent-DefaultStationBeacon.desc }
Comment on lines +55 to 57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Исправьте регистр суффикса для соответствия правилам кодирования

Согласно правилам кодирования, все переводы, начинающиеся с 'ent-', должны иметь первую букву в верхнем регистре после знака '='. Необходимо изменить регистр слова 'inspector'.

Примените следующие изменения:

 ent-DefaultStationBeaconInspector = { ent-DefaultStationBeacon }
-    .suffix = inspector
+    .suffix = Inspector
     .desc = { ent-DefaultStationBeacon.desc }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-DefaultStationBeaconInspector = { ent-DefaultStationBeacon }
.suffix = inspector
.desc = { ent-DefaultStationBeacon.desc }
ent-DefaultStationBeaconInspector = { ent-DefaultStationBeacon }
.suffix = Inspector
.desc = { ent-DefaultStationBeacon.desc }

12 changes: 6 additions & 6 deletions ...rces/Locale/en-US/ss14-ru/prototypes/deltav/entities/structures/doors/airlocks/access.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,20 @@ ent-AirlockJusticeLocked = { ent-AirlockJustice }
ent-AirlockJusticeGlassLocked = { ent-AirlockJusticeGlass }
.suffix = Justice, Locked
.desc = { ent-AirlockJusticeGlass.desc }
ent-AirlockProsecutorLocked = { ent-AirlockJustice }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вернуть AirlockProsecutorLocked

.suffix = Prosecutor, Locked
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вернуть суффикс Prosecutor

ent-AirlockInspectorLocked = { ent-AirlockJustice }
.suffix = Inspector, Locked
.desc = { ent-AirlockJustice.desc }
ent-AirlockProsecutorGlassLocked = { ent-AirlockJusticeGlass }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вернуть AirlockProsecutorGlassLocked

.suffix = Prosecutor, Locked
ent-AirlockInspectorGlassLocked = { ent-AirlockJusticeGlass }
.suffix = Inspector, Locked
.desc = { ent-AirlockJusticeGlass.desc }
ent-AirlockMaintChiefJusticeLocked = { ent-AirlockMaint }
.suffix = ChiefJustice, Locked
.desc = { ent-AirlockMaint.desc }
ent-AirlockMaintJusticeLocked = { ent-AirlockMaint }
.suffix = Justice, Locked
.desc = { ent-AirlockMaint.desc }
ent-AirlockMaintProsecutorLocked = { ent-AirlockMaint }
.suffix = Prosecutor, Locked
ent-AirlockMaintInspectorLocked = { ent-AirlockMaint }
.suffix = Inspector, Locked
.desc = { ent-AirlockMaint.desc }
ent-AirlockCorpsmanLocked = { ent-AirlockSecurity }
.suffix = Corpsman, Locked
Expand Down
4 changes: 2 additions & 2 deletions ...ces/Locale/en-US/ss14-ru/prototypes/deltav/entities/structures/doors/windoors/windoor.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ ent-WindoorSecureChiefJusticeLocked = { ent-WindoorSecure }
ent-WindoorSecureJusticeLocked = { ent-WindoorSecure }
.suffix = Justice, Locked
.desc = { ent-WindoorSecure.desc }
ent-WindoorSecureProsecutorLocked = { ent-WindoorSecure }
.suffix = Prosecutor, Locked
ent-WindoorSecureInspectorLocked = { ent-WindoorSecure }
.suffix = Inspector, Locked
.desc = { ent-WindoorSecure.desc }
ent-WindoorSecureLawyerLocked = { ent-WindoorSecure }
.suffix = Lawyer, Locked
Expand Down
4 changes: 2 additions & 2 deletions ...rces/Locale/en-US/ss14-ru/prototypes/entities/objects/devices/electronics/door_access.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ ent-DoorElectronicsChiefJustice = { ent-DoorElectronics }
ent-DoorElectronicsJustice = { ent-DoorElectronics }
.suffix = Justice, Locked
.desc = { ent-DoorElectronics.desc }
ent-DoorElectronicsProsecutor = { ent-DoorElectronics }
.suffix = Prosecutor, Locked
ent-DoorElectronicsInspector = { ent-DoorElectronics }
.suffix = Inspector, Locked
.desc = { ent-DoorElectronics.desc }
ent-DoorElectronicsMantis = { ent-DoorElectronics }
.suffix = Mantis, Locked
Expand Down
2 changes: 1 addition & 1 deletion Resources/Locale/en-US/ss14-ru/prototypes/entities/objects/misc/identification_cards.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ ent-ChiefJusticeIDCard = chief justice ID card
.desc = { ent-IDCardStandard.desc }
ent-ClerkIDCard = clerk ID card
.desc = { ent-IDCardStandard.desc }
ent-ProsecutorIDCard = presecutor ID card
ent-InspectorIDCard = presecutor ID card
.desc = { ent-IDCardStandard.desc }
Comment on lines +63 to 64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Необходимо исправить название и форматирование карты Инспектора

В строке обнаружены следующие проблемы:

  1. Некорректный перевод "presecutor" - должно быть "Inspector" согласно целям PR
  2. Текст после знака "=" должен начинаться с заглавной буквы согласно правилам кодирования

Примените следующие изменения:

-ent-InspectorIDCard = presecutor ID card
+ent-InspectorIDCard = Inspector ID card
    .desc = { ent-IDCardStandard.desc }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-InspectorIDCard = presecutor ID card
.desc = { ent-IDCardStandard.desc }
ent-InspectorIDCard = Inspector ID card
.desc = { ent-IDCardStandard.desc }

ent-HoPIDCard = head of personnel ID card
.desc = { ent-IDCardStandard.desc }
Expand Down
2 changes: 1 addition & 1 deletion Resources/Locale/ru-RU/deltav/job/job-description.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
job-description-medical-borg = Наполовину человек, наполовину машина. Следуйте своим законам, служите команде и помогайте медицинскому отделу.
job-description-chief-justice = Руководите министерством Юридического отдела, выступайте в роли судьи и следите за тем, чтобы ко всем относились справедливо.
job-description-clerk = Организуйте судебные процессы, нотариально заверяйте документы, рассматривайте обвинения и при необходимости выступайте в качестве судьи
job-description-prosecutor = Принимайте заявления от службы безопасности и готовьте дела против тех, кто обвиняется в совершении преступлений.
job-description-Inspector = Принимайте заявления от службы безопасности и готовьте дела против тех, кто обвиняется в совершении преступлений.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Исправьте регистр в ключе локализации.

Ключ локализации должен быть в нижнем регистре для соответствия стилю других записей в файле.

Примените следующие изменения:

-job-description-Inspector = Принимайте заявления от службы безопасности и готовьте дела против тех, кто обвиняется в совершении преступлений.
+job-description-inspector = Принимайте заявления от службы безопасности и готовьте дела против тех, кто обвиняется в совершении преступлений.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
job-description-Inspector = Принимайте заявления от службы безопасности и готовьте дела против тех, кто обвиняется в совершении преступлений.
job-description-inspector = Принимайте заявления от службы безопасности и готовьте дела против тех, кто обвиняется в совершении преступлений.

job-description-courier = Доставляйте почту и другие посылки в отдел снабжения. Избегайте собак.
2 changes: 1 addition & 1 deletion Resources/Locale/ru-RU/deltav/job/job-names.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
job-name-medical-borg = Медицинский киборг
job-name-chief-justice = Верховный Судья
job-name-clerk = Судья
job-name-prosecutor = Прокурор
job-name-inspector = Инспектор
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Обнаружено нарушение алфавитного порядка

Текущий порядок в файле не соответствует алфавитному. Рекомендуемый порядок:

  • "Адвокат" должен быть первым
  • "Верховный Судья" должен быть вторым
  • "Инспектор" должен быть третьим
  • "Курьер" должен быть четвертым
  • "Медицинский киборг" должен быть пятым
  • "Судья" должен быть последним

Пожалуйста, измените порядок записей в файле в соответствии с русским алфавитом для улучшения читаемости и поддержки.

🔗 Analysis chain

Изменение корректно реализовано!

Перевод должности "Inspector" как "Инспектор" выполнен верно и соответствует формату файла. Однако рекомендуется проверить, соблюдается ли алфавитный порядок на русском языке для всех должностей в файле.

Let me check the actual order in the file to compare with the sorted list.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Проверка алфавитного порядка должностей в файле локализации

echo "Текущий порядок должностей:"
grep "job-name-" "Resources/Locale/ru-RU/deltav/job/job-names.ftl" | cut -d'=' -f2 | sort -f

echo -e "\nСравните с текущим порядком в файле для проверки алфавитного порядка."

Length of output: 380

Script:

#!/bin/bash
# Description: Получить текущий порядок в файле
echo "Порядок в файле:"
grep "job-name-" "Resources/Locale/ru-RU/deltav/job/job-names.ftl" | cut -d'=' -f2

Length of output: 193

job-name-lawyer = Адвокат
job-name-courier = Курьер
2 changes: 1 addition & 1 deletion Resources/Locale/ru-RU/deltav/navmap-beacons/station-beacons.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ station-beacon-park = Парк
station-beacon-corpsman = Полевой Врач
station-beacon-justice = Судебная
station-beacon-chiefjustice = Верховный Судья
station-beacon-prosecutor = Прокурор
station-beacon-Inspector = Инспектор
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Исправьте регистр в ключе локализации

Ключ station-beacon-Inspector использует заглавную букву 'I', что не соответствует стилю именования других ключей в файле. Все остальные ключи используют нижний регистр.

Примените следующие изменения:

-station-beacon-Inspector = Инспектор
+station-beacon-inspector = Инспектор
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
station-beacon-Inspector = Инспектор
station-beacon-inspector = Инспектор

2 changes: 1 addition & 1 deletion Resources/Locale/ru-RU/deltav/prototypes/access/accesses.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
id-card-access-level-orders = Заказы
id-card-access-level-mantis = Мантис
id-card-access-level-cj = Верховный Судья
id-card-access-level-prosecutor = Прокурор
id-card-access-level-Inspector = Инспектор
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Исправьте формат идентификатора доступа

Идентификатор id-card-access-level-Inspector не соответствует конвенции именования. Все остальные идентификаторы в файле используют нижний регистр.

Примените следующие изменения:

-id-card-access-level-Inspector = Инспектор
+id-card-access-level-inspector = Инспектор
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
id-card-access-level-Inspector = Инспектор
id-card-access-level-inspector = Инспектор

id-card-access-level-justice = Суд
id-card-access-level-corpsman = Полевой Врач
4 changes: 2 additions & 2 deletions Resources/Locale/ru-RU/ss14-ru/prototypes/deltav/entities/clothing/neck/misc.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
ent-ClothingNeckProsecutorbadge = Значок прокурора
.desc = Значок который выдают лицензированным прокурорам юридического департамента корпорации NT.
ent-ClothingNeckInspectorbadge = Значок инспектора
.desc = Значок который выдают лицензированным инспекторам юридического департамента корпорации NT.
4 changes: 2 additions & 2 deletions Resources/Locale/ru-RU/ss14-ru/prototypes/deltav/entities/clothing/uniforms/jumpskirts.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ ent-ClothingUniformJumpskirtChiefJustice = Юбка-комбинезон вер
.desc = Деловой наряд в сочетании с кружевным галстуком. Его носят лишь самые деловые личности.
ent-ClothingUniformJumpskirtClerk = Юбка-комбинезон судьи
.desc = Скромная юбка для тех, кто может записать любую информацию.
ent-ClothingUniformJumpskirtProsecutor = Юбка-комбинезон прокурора
.desc = Красная юбка в сочетании с костюмом и деловым галстуком. Идеальный вариант для прокурора.
ent-ClothingUniformJumpskirtInspector = Юбка-комбинезон инспектора
.desc = Красная юбка в сочетании с костюмом и деловым галстуком. Идеальный вариант для инспектора.
4 changes: 2 additions & 2 deletions Resources/Locale/ru-RU/ss14-ru/prototypes/deltav/entities/clothing/uniforms/jumpsuits.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,5 @@ ent-ClothingUniformJumpsuitClerk = Костюм судьи
.desc = Скромный костюм для человека, имеющего право нотариально заверять что угодно.
ent-ClothingUniformJumpsuitChemShirt = Официальный костюм химика
.desc = На этом костюме все еще старые пятная. Хм.
ent-ClothingUniformJumpsuitProsecutor = Костюм прокурора
.desc = Красный костюм с нарядным галстуком. Идеально подходит для прокурора.
ent-ClothingUniformJumpsuitInspector = Костюм инспектора
.desc = Красный костюм с нарядным галстуком. Идеально подходит для инспектора.
2 changes: 1 addition & 1 deletion Resources/Locale/ru-RU/ss14-ru/prototypes/deltav/entities/markers/spawners/jobs.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ent-SpawnPointChiefJustice = Спавнер верховного судьи
.desc = { ent-SpawnPointJobBase.desc }
ent-SpawnPointClerk = Спавнер судьи
.desc = { ent-SpawnPointJobBase.desc }
ent-SpawnPointProsecutor = Спавнер прокурора
ent-SpawnPointInspector = Спавнер инспектора
.desc = { ent-SpawnPointJobBase.desc }
Comment on lines +7 to 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Исправьте регистр первой буквы после знака равенства

Согласно правилам кодирования, все переводы, начинающиеся с "ent-", должны иметь заглавную букву после знака равенства.

Примените следующие изменения:

-ent-SpawnPointInspector = Спавнер инспектора
+ent-SpawnPointInspector = Cпавнер инспектора

Committable suggestion skipped: line range outside the PR's diff.

ent-SpawnPointCourier = Спавнер курьера
.desc = { ent-SpawnPointJobBase.desc }
2 changes: 1 addition & 1 deletion Resources/Locale/ru-RU/ss14-ru/prototypes/deltav/entities/objects/devices/pda.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ent-ChiefJusticePDA = КПК верховного судьи
.desc = Носитель этого КПК имеет истинную власть на этой станции.
ent-ClerkPDA = КПК судьи
.desc = На корпусе можно замечить печать, доказывающая, что этот КПК был заверен его носителю.
ent-ProsecutorPDA = КПК прокурора
ent-InspectorPDA = КПК инспектора
.desc = Дерзкий дизайн. Выглядит так, словно он готов вести чьё-то судебное дело.
ent-SyndiListeningPostPDA = { ent-SyndiPDA }
.desc = { ent-SyndiPDA.desc }
4 changes: 2 additions & 2 deletions Resources/Locale/ru-RU/ss14-ru/prototypes/deltav/entities/objects/devices/station_beacon.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,6 @@ ent-DefaultStationBeaconJustice = { ent-DefaultStationBeacon }
ent-DefaultStationBeaconChiefJustice = { ent-DefaultStationBeaconJustice }
.suffix = Кабинет верховного судьи
.desc = { ent-DefaultStationBeaconJustice.desc }
ent-DefaultStationBeaconProsecutor = { ent-DefaultStationBeacon }
.suffix = Кабинет прокурора
ent-DefaultStationBeaconInspector = { ent-DefaultStationBeacon }
.suffix = Кабинет инспектора
Comment on lines +55 to +56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Изменения соответствуют требованиям локализации

Структура и формат новой записи маяка для Инспектора корректны и соответствуют общему стилю файла. Для улучшения читаемости рекомендуется использовать заглавную букву в начале значения суффикса.

 ent-DefaultStationBeaconInspector = { ent-DefaultStationBeacon }
-    .suffix = Кабинет инспектора
+    .suffix = Кабинет Инспектора
     .desc = { ent-DefaultStationBeacon.desc }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-DefaultStationBeaconInspector = { ent-DefaultStationBeacon }
.suffix = Кабинет инспектора
ent-DefaultStationBeaconInspector = { ent-DefaultStationBeacon }
.suffix = Кабинет Инспектора
.desc = { ent-DefaultStationBeacon.desc }

.desc = { ent-DefaultStationBeacon.desc }
12 changes: 6 additions & 6 deletions ...rces/Locale/ru-RU/ss14-ru/prototypes/deltav/entities/structures/doors/airlocks/access.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,20 @@ ent-AirlockJusticeLocked = { ent-AirlockJustice }
ent-AirlockJusticeGlassLocked = { ent-AirlockJusticeGlass }
.suffix = Судья, Закрыто
.desc = { ent-AirlockJusticeGlass.desc }
ent-AirlockProsecutorLocked = { ent-AirlockJustice }
.suffix = Прокурор, Закрыто
ent-AirlockInspectorLocked = { ent-AirlockJustice }
.suffix = Инспектор, Закрыто
.desc = { ent-AirlockJustice.desc }
ent-AirlockProsecutorGlassLocked = { ent-AirlockJusticeGlass }
.suffix = Прокурор, Закрыто
ent-AirlockInspectorGlassLocked = { ent-AirlockJusticeGlass }
.suffix = Инспектор, Закрыто
.desc = { ent-AirlockJusticeGlass.desc }
ent-AirlockMaintChiefJusticeLocked = { ent-AirlockMaint }
.suffix = Верховный Судья, Закрыто
.desc = { ent-AirlockMaint.desc }
ent-AirlockMaintJusticeLocked = { ent-AirlockMaint }
.suffix = Судья, Закрыто
.desc = { ent-AirlockMaint.desc }
ent-AirlockMaintProsecutorLocked = { ent-AirlockMaint }
.suffix = Прокурор, Закрыто
ent-AirlockMaintInspectorLocked = { ent-AirlockMaint }
.suffix = Инспектор, Закрыто
.desc = { ent-AirlockMaint.desc }
ent-AirlockCorpsmanLocked = { ent-AirlockSecurity }
.suffix = Полевой Врач, Закрыто
Expand Down
4 changes: 2 additions & 2 deletions ...ces/Locale/ru-RU/ss14-ru/prototypes/deltav/entities/structures/doors/windoors/windoor.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ ent-WindoorSecureChiefJusticeLocked = { ent-WindoorSecure }
ent-WindoorSecureJusticeLocked = { ent-WindoorSecure }
.suffix = Судья, Закрыто
.desc = { ent-WindoorSecure.desc }
ent-WindoorSecureProsecutorLocked = { ent-WindoorSecure }
.suffix = Прокурор, Закрыто
ent-WindoorSecureInspectorLocked = { ent-WindoorSecure }
.suffix = Инспектор, Закрыто
.desc = { ent-WindoorSecure.desc }
ent-WindoorSecureLawyerLocked = { ent-WindoorSecure }
.suffix = Законник, Закрыто
Expand Down
4 changes: 2 additions & 2 deletions ...rces/Locale/ru-RU/ss14-ru/prototypes/entities/objects/devices/electronics/door_access.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ ent-DoorElectronicsChiefJustice = { ent-DoorElectronics }
ent-DoorElectronicsJustice = { ent-DoorElectronics }
.suffix = Судья, Закрыт
.desc = { ent-DoorElectronics.desc }
ent-DoorElectronicsProsecutor = { ent-DoorElectronics }
.suffix = Прокурор, Закрыт
ent-DoorElectronicsInspector = { ent-DoorElectronics }
.suffix = Инспектор, Закрыт
.desc = { ent-DoorElectronics.desc }
ent-DoorElectronicsMantis = { ent-DoorElectronics }
.suffix = Мантис, Закрыт
Expand Down
2 changes: 1 addition & 1 deletion Resources/Locale/ru-RU/ss14-ru/prototypes/entities/objects/misc/identification_cards.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ ent-ChiefJusticeIDCard = ID карта верховного судьи
.desc = { ent-IDCardStandard.desc }
ent-ClerkIDCard = ID карта судьи
.desc = { ent-IDCardStandard.desc }
ent-ProsecutorIDCard = ID карта прокурора
ent-InspectorIDCard = ID карта инспектора
.desc = { ent-IDCardStandard.desc }
ent-HoPIDCard = ID карта главы персонала
.desc = { ent-IDCardStandard.desc }
Expand Down
2 changes: 1 addition & 1 deletion Resources/Maps/_LostParadise/Hell/H_LPPAsterisk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61358,7 +61358,7 @@ entities:
- type: Transform
pos: -34.5,16.5
parent: 2
- proto: SpawnPointProsecutor
- proto: SpawnPointInspector
entities:
- uid: 11201
components:
Expand Down
4 changes: 2 additions & 2 deletions Resources/Maps/_LostParadise/Hell/H_LPPKerberos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254922,7 +254922,7 @@ entities:
- type: Transform
pos: 72.5,17.5
parent: 2
- proto: SpawnPointProsecutor
- proto: SpawnPointInspector
entities:
- uid: 44087
components:
Expand Down Expand Up @@ -259844,7 +259844,7 @@ entities:
setupAvailableNetworks:
- SurveillanceCameraService
nameSet: True
id: Офис Адвоката\Прокурора
id: Офис Адвоката\Инспектора
- uid: 39703
components:
- type: Transform
Expand Down
4 changes: 2 additions & 2 deletions Resources/Maps/_LostParadise/Hell/H_LPPNormandy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92097,7 +92097,7 @@ entities:
- type: Transform
pos: -39.5,7.5
parent: 2
- proto: SpawnPointProsecutor
- proto: SpawnPointInspector
entities:
- uid: 8343
components:
Expand Down Expand Up @@ -113956,7 +113956,7 @@ entities:
pos: -8.5,-4.5
parent: 2
- type: WarpPoint
location: Офис Адвокатов\Прокуроров
location: Офис Адвокатов\Инспекторов
- proto: WarpPointLibrary
entities:
- uid: 7194
Expand Down
2 changes: 1 addition & 1 deletion Resources/Maps/_LostParadise/Hell/H_LPPPebble.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61071,7 +61071,7 @@ entities:
- type: Transform
pos: -27.5,-20.5
parent: 2
- proto: SpawnPointProsecutor
- proto: SpawnPointInspector
entities:
- uid: 11026
components:
Expand Down
2 changes: 1 addition & 1 deletion Resources/Maps/_LostParadise/LPPAsterisk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59657,7 +59657,7 @@ entities:
- type: Transform
pos: -34.5,16.5
parent: 2
- proto: SpawnPointProsecutor
- proto: SpawnPointInspector
entities:
- uid: 11201
components:
Expand Down
4 changes: 2 additions & 2 deletions Resources/Maps/_LostParadise/LPPKerberos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249815,7 +249815,7 @@ entities:
- type: Transform
pos: 72.5,17.5
parent: 2
- proto: SpawnPointProsecutor
- proto: SpawnPointInspector
entities:
- uid: 44087
components:
Expand Down Expand Up @@ -254377,7 +254377,7 @@ entities:
setupAvailableNetworks:
- SurveillanceCameraService
nameSet: True
id: Офис Адвоката\Прокурора
id: Офис Адвоката\Инспектора
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Рекомендуется использовать английский язык для идентификаторов

Согласно правилам кодирования, в прототипах следует избегать использования русского языка. Предлагаю заменить идентификатор на английский вариант.

-      id: Офис Адвоката\Инспектора
+      id: Lawyer\Inspector Office
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
id: Офис Адвоката\Инспектора
id: Lawyer\Inspector Office

- uid: 39703
components:
- type: Transform
Expand Down
4 changes: 2 additions & 2 deletions Resources/Maps/_LostParadise/LPPNormandy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89325,7 +89325,7 @@ entities:
- type: Transform
pos: -39.5,7.5
parent: 2
- proto: SpawnPointProsecutor
- proto: SpawnPointInspector
entities:
- uid: 8343
components:
Expand Down Expand Up @@ -111104,7 +111104,7 @@ entities:
pos: -8.5,-4.5
parent: 2
- type: WarpPoint
location: Офис Адвокатов\Прокуроров
location: Офис Адвокатов\Инспекторов
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Необходимо убрать русский текст из прототипа!

Согласно правилам кодирования, в прототипах запрещены переводы на русский язык. Текст должен быть на английском или реализован через ссылку на перевод.

Предлагаемое исправление:

-      location: Офис Адвокатов\Инспекторов
+      location: Office-Advocates-Inspectors

Также рекомендуется добавить соответствующий перевод в файл локализации.

Committable suggestion skipped: line range outside the PR's diff.

- proto: WarpPointLibrary
entities:
- uid: 7194
Expand Down
2 changes: 1 addition & 1 deletion Resources/Maps/_LostParadise/LPPPebble.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59905,7 +59905,7 @@ entities:
- type: Transform
pos: -27.5,-20.5
parent: 2
- proto: SpawnPointProsecutor
- proto: SpawnPointInspector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Прототип SpawnPointInspector находится вне папки _LostParadise

Прототип SpawnPointInspector определен в Resources/Prototypes/DeltaV/Entities/Markers/Spawners/jobs.yml, что не соответствует требованию о размещении прототипов в "нашей" папке (_LostParadise).

  • Необходимо перенести прототип SpawnPointInspector в папку Resources/Prototypes/_LostParadise/
  • Обновить все ссылки на прототип после переноса
🔗 Analysis chain

Изменение прототипа соответствует требованиям.

Замена SpawnPointProsecutor на SpawnPointInspector корректна и соответствует целям PR.

Давайте проверим существование прототипа в правильной локации:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Проверяем существование прототипа SpawnPointInspector в нашей папке
fd "SpawnPointInspector" Resources/Prototypes/_LostParadise/

Length of output: 60

Script:

#!/bin/bash
# Расширим поиск на всю директорию Resources/Prototypes
fd "SpawnPointInspector" Resources/Prototypes/

# Также проверим содержимое файлов на наличие определения прототипа
rg "SpawnPointInspector" Resources/Prototypes/ -A 5

Length of output: 605

entities:
- uid: 11026
components:
Expand Down
2 changes: 1 addition & 1 deletion Resources/Maps/_LostParadise/LPPSubmarine.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210969,7 +210969,7 @@ entities:
- type: Transform
pos: -7.5,64.5
parent: 2
- proto: SpawnPointProsecutor
- proto: SpawnPointInspector
entities:
- uid: 15687
components:
Expand Down
Loading
Loading