Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/display identification #25

Merged
merged 43 commits into from
Oct 1, 2024
Merged

Fix/display identification #25

merged 43 commits into from
Oct 1, 2024

Conversation

BryanChrisBrown
Copy link
Contributor

@BryanChrisBrown BryanChrisBrown commented May 28, 2024 •
edited
Loading

library

  • updates the types for hologram parameters we can send to Bridge.

react-app

  • update the playlist and updateParams component for better usability
  • update the display section to be more clear

@rongxin-liu rongxin-liu mentioned this pull request Sep 27, 2024
Closed
@rongxin-liu
Copy link
Contributor

Refs: LKG-946

@rongxin-liu rongxin-liu mentioned this pull request Sep 30, 2024
Closed
rongxin-liu
rongxin-liu reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@rongxin-liu rongxin-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Let's format all the files before merging.

@BryanChrisBrown BryanChrisBrown merged commit 0fc6aca into main Oct 1, 2024
1 check passed
@BryanChrisBrown BryanChrisBrown deleted the fix/display-identification branch October 1, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rongxin-liu rongxin-liu rongxin-liu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BryanChrisBrown @rongxin-liu