Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export aspect ratio parameter #29

Closed
wants to merge 2 commits into from

Conversation

rongxin-liu
Copy link
Contributor

@rongxin-liu rongxin-liu commented Sep 26, 2024

Fixes LKG-946

Related PR #25

Copy link

linear bot commented Sep 26, 2024

@rongxin-liu rongxin-liu changed the title Export aspect ratio param Export aspect ratio parameter Sep 26, 2024
@rongxin-liu rongxin-liu self-assigned this Sep 26, 2024
@rongxin-liu rongxin-liu added the enhancement New feature or request label Sep 26, 2024
@rongxin-liu
Copy link
Contributor Author

rongxin-liu commented Sep 26, 2024

In theory, after exporting aspect param, calling updateCurrentHologram() to update the aspect ratio of the hologram being cast should work:

import { BridgeClient } from "@lookingglass/bridge"
const Bridge = BridgeClient.getInstance()
Bridge.updateCurrentHologram({
    name: "some_name",
    parameter: "aspect",
    value: 0.75,
})

However, it seems that Bridge is ignoring the update. Could these lines of code be related?

https://github.com/Looking-Glass/LookingGlassBridge/blob/master/service_engine/agnostic/Orchestration.cpp#L1507-L1518

@BryanChrisBrown
Copy link
Contributor

let's keep this open until bridge actually supports this parameter

@rongxin-liu
Copy link
Contributor Author

rongxin-liu commented Sep 27, 2024

let's keep this open until bridge actually supports this parameter

Sounds good, though in fact this PR could be closed once #25 is merged because the same changes were made in that PR.

@rongxin-liu rongxin-liu marked this pull request as draft September 27, 2024 20:08
@rongxin-liu
Copy link
Contributor Author

Superseded buy #25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants