Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Color Modifications #41

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ThatHypedPerson
Copy link
Contributor

This is just a basic implementation of all the things I think should have options to be colored so far. I also currently have colors working for Tatl and the File Select screen, but I'm not sure if I should add them here.

I think that any logic/presets for the colors should be handled via the apworld rather than the mod since they are being sent anyways, and they should also default to vanilla colors if nothing is provided.

all colors temporarily set to their defaults
@LittleCube-hax
Copy link
Owner

Holy hell, this is legit.

I'd love to also have your Tatl and File Select changes as well, if you're willing to push them.

When this gets merged, for now I'll add code to handle the settings through the YAML, but eventually this code will probably be used for a standalone color mod with its own UI for setting it whenever the player wishes.

@ThatHypedPerson
Copy link
Contributor Author

ThatHypedPerson commented Nov 13, 2024

Alright I went ahead and added them.

Also I agree that when the GUI for mods is released that this should be its own mod, so I'll be keeping my own mod updated in parallel for when that time comes.

@ThatHypedPerson

This comment was marked as outdated.

@ThatHypedPerson
Copy link
Contributor Author

Actually disregard what I said above, since this solution wouldn't work with Zora Link/Fierce Deity.

Those forms have textures that would force me into properly implementing the features that allow for these changes without requiring the textures.

So I could still implement Deku/Goron + some of Zora with included textures, but I'll hold off on that for now.

also hides sun's song in the pause menu for if it get's added
@LittleCube-hax
Copy link
Owner

LittleCube-hax commented Nov 29, 2024

Sorry, just saw these other comments.

That looks great! I'd happily accept any implementation you have that works with Deku/Goron at least if possible.

Edit: I just understood what you meant 🥴 I see now. If you could figure out the implementation for no included textures that would be absolutely sick, in the meantime if you're ready I'd love to merge this whenever you think it's in a good state (and if you see changes that need to be made, I can definitely merge in additional PRs).

@ThatHypedPerson
Copy link
Contributor Author

ThatHypedPerson commented Nov 30, 2024

I'll probably hold off on adding the other forms until there's more modding documentation. Mainly, I'm not sure how most ideas I have so far to implement them would work with texture packs.

Also completely forgot to commit a few more changes I made so I'll go ahead and add those right now. I think currently its in a state that should be good to merge, but since nearly everything outside of player models are easy enough to modify I might add them in as well (i.e. rupees, other HUD elements, item drops?).

I was also thinking if these additions should be in a standalone mod that interfaces with something like MMRecompAPCppGlue instead of within this mod. It could still be included with the other mods in releases, but it would also make it easier in the future when we're able to add a UI to it. Let me know what you think of that though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants