-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MuSig2 support #294
base: develop
Are you sure you want to change the base?
MuSig2 support #294
Commits on Nov 4, 2024
-
Added parsing for musig(); generalized key placeholders in wallet pol…
…icies to more general key expressions
Configuration menu - View commit details
-
Copy full SHA for f962150 - Browse repository at this point
Copy the full SHA f962150View commit details -
Rename "key placeholder" with "key expression" where appropriate; add…
…ed some comments. Generalizing to key expressions containing musig() makes it necessary to distinguish the key expressions in the wallet policy from the actual key placeholders that are just indexes to the list of key informations (@num in the descriptor template), whereas the two concepts were often not clearly separated in the code base. Renaming to "key expressions" makes the distinction more clear.
Configuration menu - View commit details
-
Copy full SHA for 5efbc36 - Browse repository at this point
Copy the full SHA 5efbc36View commit details -
Refactored policy_node_keyexpr_t to explicitly label which of the uni…
…on type is used; generalized some parts of the code that are not generalized to musig key expressions, and annotated some others.
Configuration menu - View commit details
-
Copy full SHA for 8e24994 - Browse repository at this point
Copy the full SHA 8e24994View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dbf464 - Browse repository at this point
Copy the full SHA 3dbf464View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92f1b54 - Browse repository at this point
Copy the full SHA 92f1b54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e6bae5 - Browse repository at this point
Copy the full SHA 4e6bae5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 654e1e2 - Browse repository at this point
Copy the full SHA 654e1e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbde126 - Browse repository at this point
Copy the full SHA bbde126View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b7af76 - Browse repository at this point
Copy the full SHA 7b7af76View commit details
Commits on Nov 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4ebfc25 - Browse repository at this point
Copy the full SHA 4ebfc25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f48eb8 - Browse repository at this point
Copy the full SHA 9f48eb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f28011 - Browse repository at this point
Copy the full SHA 7f28011View commit details -
Add parsing of Musig2 pubnonces and partial signatures as yielded val…
…ues in sign_psbt in the python client
Configuration menu - View commit details
-
Copy full SHA for acc0530 - Browse repository at this point
Copy the full SHA acc0530View commit details
Commits on Nov 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3327a8e - Browse repository at this point
Copy the full SHA 3327a8eView commit details -
Update musig() specs, and fix psbt processing
- musig() now sorts the keys, as per the BIP draft - correctly compute fingerprint for musig() aggregate key - added both the aggregate and the internal key in keyexpr_info_t struct - fixed psbt parsing logic to detect change/addr_index for musig - updated musig tests
Configuration menu - View commit details
-
Copy full SHA for 41be6f1 - Browse repository at this point
Copy the full SHA 41be6f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c15335c - Browse repository at this point
Copy the full SHA c15335cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0e02d0 - Browse repository at this point
Copy the full SHA b0e02d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b3061b - Browse repository at this point
Copy the full SHA 1b3061bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 27c95dc - Browse repository at this point
Copy the full SHA 27c95dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 16261f5 - Browse repository at this point
Copy the full SHA 16261f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b51ab8 - Browse repository at this point
Copy the full SHA 5b51ab8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3418b60 - Browse repository at this point
Copy the full SHA 3418b60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e13101 - Browse repository at this point
Copy the full SHA 8e13101View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad377fb - Browse repository at this point
Copy the full SHA ad377fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38a9e80 - Browse repository at this point
Copy the full SHA 38a9e80View commit details -
Fix read_change_and_index_from_psbt_bip32_derivation incorrectly abor…
…ting prematurely for some PSBTs. Added explanatory comment
Configuration menu - View commit details
-
Copy full SHA for aea89fd - Browse repository at this point
Copy the full SHA aea89fdView commit details -
Removed unused argument; deleted commented out check
The check doesn't serve a security purpose, since direct derivation of each input/change script is used to check if they are internal.
Configuration menu - View commit details
-
Copy full SHA for 13abab8 - Browse repository at this point
Copy the full SHA 13abab8View commit details -
Generalized count_internal_keys in the test suite to count_internal_k…
…ey_placeholders, with musig placeholder support
Configuration menu - View commit details
-
Copy full SHA for 5fcdcdf - Browse repository at this point
Copy the full SHA 5fcdcdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1192d10 - Browse repository at this point
Copy the full SHA 1192d10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c8fb7e - Browse repository at this point
Copy the full SHA 6c8fb7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4189823 - Browse repository at this point
Copy the full SHA 4189823View commit details -
Configuration menu - View commit details
-
Copy full SHA for 712bfa7 - Browse repository at this point
Copy the full SHA 712bfa7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34f2746 - Browse repository at this point
Copy the full SHA 34f2746View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce066d7 - Browse repository at this point
Copy the full SHA ce066d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac4a48c - Browse repository at this point
Copy the full SHA ac4a48cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9645d25 - Browse repository at this point
Copy the full SHA 9645d25View commit details -
Refactor input_keys_callback output_keys_callback to match against al…
…l the internal key expressions, instead of only the first
Configuration menu - View commit details
-
Copy full SHA for 6184d44 - Browse repository at this point
Copy the full SHA 6184d44View commit details -
Added test for incomplete matching of BIP32 derivation paths in polic…
…ies with multiple internal keys
Configuration menu - View commit details
-
Copy full SHA for c5a3b92 - Browse repository at this point
Copy the full SHA c5a3b92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d25a27 - Browse repository at this point
Copy the full SHA 1d25a27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d858b4 - Browse repository at this point
Copy the full SHA 6d858b4View commit details
Commits on Nov 20, 2024
-
Detect if the PSBT has at least a PSBT_IN_MUSIG2_PUB_NONCE field
It will be needed in order to enable silently participating to Round 1 of the MuSig2 protocol, which should only happen if no such fields are found (which would indicate that Round 1 was already executed).
Configuration menu - View commit details
-
Copy full SHA for 3f556d8 - Browse repository at this point
Copy the full SHA 3f556d8View commit details
Commits on Nov 21, 2024
-
Moved MuSig2 Round 1 out of the signing flow. Allow it without user c…
…onfirmation. The first round of MuSig does not involve access to the private keys and does not complete authorizing a transaction. Therefore, it is safe to do it without user confirmation, which allows software wallets to possibly do it in background. In cases when the other cosigners are online, this allows to get a single-sig user experience, as the user would only have to plug the device once, and confirm a single action.
Configuration menu - View commit details
-
Copy full SHA for b6ce98c - Browse repository at this point
Copy the full SHA b6ce98cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 392b942 - Browse repository at this point
Copy the full SHA 392b942View commit details -
Fix wrong documentation for get_extended_pubkey; renamed to get_exten…
…ded_pubkey_from_client
Configuration menu - View commit details
-
Copy full SHA for 752aaa8 - Browse repository at this point
Copy the full SHA 752aaa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6b07ce - Browse repository at this point
Copy the full SHA e6b07ceView commit details
Commits on Nov 29, 2024
-
In the past, while the app was deployed on Nano S, we preferred avoiding the use of Nano S in order to reduce the binary size. Now, using qsort makes the code more readable and succinct.
Configuration menu - View commit details
-
Copy full SHA for 568153f - Browse repository at this point
Copy the full SHA 568153fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 715b2be - Browse repository at this point
Copy the full SHA 715b2beView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd286b3 - Browse repository at this point
Copy the full SHA bd286b3View commit details -
Add an explicit initializer for the musigsession signing state.
This is redundant with the current implementation. However, the musigsession module is written in such a way that the calling code has no knowledge about its internal working. Therefore, it should not assume that zeroing out is the correct way of initializing it.
Configuration menu - View commit details
-
Copy full SHA for b551ed4 - Browse repository at this point
Copy the full SHA b551ed4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a2a3c5 - Browse repository at this point
Copy the full SHA 4a2a3c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08a2ac0 - Browse repository at this point
Copy the full SHA 08a2ac0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42cceb4 - Browse repository at this point
Copy the full SHA 42cceb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c49167c - Browse repository at this point
Copy the full SHA c49167cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0456d6d - Browse repository at this point
Copy the full SHA 0456d6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1112d8a - Browse repository at this point
Copy the full SHA 1112d8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for daa79a3 - Browse repository at this point
Copy the full SHA daa79a3View commit details