MuSig2 support #294
Draft
MuSig2 support #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #294 +/- ##
===========================================
- Coverage 84.76% 84.67% -0.10%
===========================================
Files 17 17
Lines 2186 2231 +45
===========================================
+ Hits 1853 1889 +36
- Misses 333 342 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
…icies to more general key expressions
…ed some comments. Generalizing to key expressions containing musig() makes it necessary to distinguish the key expressions in the wallet policy from the actual key placeholders that are just indexes to the list of key informations (@num in the descriptor template), whereas the two concepts were often not clearly separated in the code base. Renaming to "key expressions" makes the distinction more clear.
…on type is used; generalized some parts of the code that are not generalized to musig key expressions, and annotated some others.
bigspider
force-pushed
the
musig2
branch
3 times, most recently
from
256f790
to
4616d67
Compare
bigspider
force-pushed
the
musig2
branch
7 times, most recently
from
aae5a24
to
261d7d6
Compare
…ting prematurely for some PSBTs. Added explanatory comment
The check doesn't serve a security purpose, since direct derivation of each input/change script is used to check if they are internal.
…ey_placeholders, with musig placeholder support
…l the internal key expressions, instead of only the first
…ies with multiple internal keys
It will be needed in order to enable silently participating to Round 1 of the MuSig2 protocol, which should only happen if no such fields are found (which would indicate that Round 1 was already executed).
| int sign_result = sign_transaction(dc, &st, cache, &signing_state, internal_inputs); | ||
|
|
||
| if (!G_swap_state.called_from_swap) { | ||
| ui_post_processing_confirm_transaction(dc, sign_result); |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
…onfirmation. The first round of MuSig does not involve access to the private keys and does not complete authorizing a transaction. Therefore, it is safe to do it without user confirmation, which allows software wallets to possibly do it in background. In cases when the other cosigners are online, this allows to get a single-sig user experience, as the user would only have to plug the device once, and confirm a single action.
…ded_pubkey_from_client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add full support for
musig()in wallet policies.Also improves the signing flow to only sign for spending paths that are filled in in the PSBT (that is, the corresponding
PSBT_IN_BIP32_DERIVATIONorPSBT_IN_TAP_BIP32_DERIVATIONfields are present), optimizing certain use cases for wallet policies with multiple alternative spending paths.Closes: #208, #177