Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Tomcat 9.0.82 #591

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Conversation

labkey-jeckels
Copy link
Contributor

Rationale

There are some bug fixes in the latest Tomcat release that we want to pick up ahead of its adoption in the upcoming Spring Boot 2.7.17. We can back out the forcing to the version when the new Spring Boot is available

Changes

  • Force to the latest Tomcat

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@labkey-jeckels labkey-jeckels changed the base branch from develop to release23.10-SNAPSHOT October 16, 2023 21:58
@LabKey LabKey deleted a comment from github-actions bot Oct 16, 2023
//
// force ":${springBootTomcatVersion}"
// force "org.apache.tomcat.embed:tomcat-embed-el:"
// force "org.apache.tomcat.embed:tomcat-embed-websocket:${springBootTomcatVersion}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably get rid of these since I think the above syntax is preferable here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cleaned them up

@labkey-jeckels labkey-jeckels merged commit 12379b6 into release23.10-SNAPSHOT Oct 17, 2023
@labkey-jeckels labkey-jeckels deleted the 23.10_fb_embeddedTomcat branch October 17, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants