Skip to content

Commit

Permalink
Adopt Tomcat 9.0.82 (#591)
Browse files Browse the repository at this point in the history
  • Loading branch information
labkey-jeckels authored Oct 17, 2023
1 parent 4d1b98b commit 12379b6
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 3 deletions.
4 changes: 2 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ apacheDirectoryVersion=2.1.3
apacheMinaVersion=2.2.1

# Keep in sync with springBootTomcatVersion below
apacheTomcatVersion=9.0.80
apacheTomcatVersion=9.0.82

# (mothership) -> json-path -> json-smart -> accessor-smart
# (core) -> graalvm
Expand Down Expand Up @@ -285,7 +285,7 @@ snappyJavaVersion=1.1.10.4
springBootVersion=2.7.16
# This MUST match the Tomcat version dictated by springBootVersion
# Also, keep this in sync with apacheTomcatVersion above
springBootTomcatVersion=9.0.80
springBootTomcatVersion=9.0.82

springVersion=5.3.28

Expand Down
29 changes: 28 additions & 1 deletion server/embedded/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,34 @@ dependencies {
implementation "org.springframework.boot:spring-boot-starter-web:${springBootVersion}"
implementation "org.springframework.boot:spring-boot-starter-actuator:${springBootVersion}"
implementation "org.springframework.boot:spring-boot-starter-validation:${springBootVersion}"


// Force to the latest Tomcat version until Spring Boot 2.7.17 is released and we can adopt it
implementation('org.apache.tomcat.embed:tomcat-embed-core') {
version {
strictly "${springBootTomcatVersion}"
}
}
implementation('org.apache.tomcat.embed:tomcat-embed-el') {
version {
strictly "${springBootTomcatVersion}"
}
}
implementation('org.apache.tomcat.embed:tomcat-embed-websocket') {
version {
strictly "${springBootTomcatVersion}"
}
}
implementation('org.apache.tomcat:tomcat-annotations-api') {
version {
strictly "${springBootTomcatVersion}"
}
}
implementation('org.apache.tomcat:tomcat-jsp-api') {
version {
strictly "${springBootTomcatVersion}"
}
}

// This is a transitive dependency from spring-boot-starter that we're forcing to pick up CVE hotfixes. We're not
// vulnerable since we're not accepting untrusted Spring Boot config files, but this cleans up the reporting.
// At some point Spring Boot should update its preferred version and we can yank this
Expand Down

0 comments on commit 12379b6

Please sign in to comment.