Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: add codecov #192

Merged
merged 2 commits into from
Jul 27, 2023
Merged

workflow: add codecov #192

merged 2 commits into from
Jul 27, 2023

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Jul 24, 2023

Closes: #169

@KevFan KevFan force-pushed the codecov branch 8 times, most recently from 84e455d to 4318d9b Compare July 25, 2023 09:13
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@775596d). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage        ?   73.46%           
=======================================
  Files           ?       29           
  Lines           ?     4786           
  Branches        ?        0           
=======================================
  Hits            ?     3516           
  Misses          ?     1270           
  Partials        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@KevFan KevFan marked this pull request as ready for review July 26, 2023 15:37
@KevFan KevFan requested a review from a team July 26, 2023 16:21
Copy link
Member

@alexsnaps alexsnaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this as is for now, but if we get some issues with the tests with nightly (we shouldn't but... famous last words) - we may want to run tests on stable (without coverage) too. Also, leaving this for reference...

@KevFan KevFan merged commit de002e5 into Kuadrant:main Jul 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup CodeCov integration
3 participants