Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codecov badge using wrong branch #194

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Jul 27, 2023

  • Codecov badge was using master instead of main so the code coverage percentage was not shown from inital work in workflow: add codecov #192

@KevFan KevFan marked this pull request as ready for review July 27, 2023 14:13
@KevFan KevFan requested a review from a team July 27, 2023 14:13
@codecov-commenter
Copy link

Codecov Report

Merging #194 (d2dc4cb) into main (de002e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   73.68%   73.68%           
=======================================
  Files          29       29           
  Lines        4910     4910           
=======================================
  Hits         3618     3618           
  Misses       1292     1292           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@KevFan KevFan merged commit d2e0d0d into Kuadrant:main Jul 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants