Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE] feat(proxy-wasm) new 'request.is_subrequest' property #666

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

thibaultcha
Copy link
Member

@thibaultcha thibaultcha commented Jan 16, 2025

Introduce a new request property request.is_subrequest to indicate whether the current request is a subrequest of an existing request (e.g. in slicing scenarios).

Note: Although the property uses the request.* prefix, this is not an Envoy attribute.

  • documentation

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.83458%. Comparing base (0c9eeed) to head (312c4b0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/common/proxy_wasm/ngx_proxy_wasm_properties.c 92.85714% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #666         +/-   ##
===================================================
+ Coverage   90.79446%   90.83458%   +0.04012%     
===================================================
  Files             53          53                 
  Lines          11341       11347          +6     
  Branches        1690        1690                 
===================================================
+ Hits           10297       10307         +10     
+ Misses          1038        1034          -4     
  Partials           6           6                 
Files with missing lines Coverage Δ
src/common/proxy_wasm/ngx_proxy_wasm_properties.c 89.71554% <92.85714%> (+0.58029%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
unit 90.57797% <100.00000%> (+0.02670%) ⬆️
valgrind 82.48830% <57.14286%> (+0.02975%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@thibaultcha thibaultcha force-pushed the feat/request.is_subrequest-merge branch 2 times, most recently from abf55f0 to 8ae948e Compare January 16, 2025 23:41
Introduce a new request property `request.is_subrequest` to indicate
whether the current request is a subrequest of an existing request
(e.g. in slicing scenarios).

Note: although the property uses the `request.*` prefix, this is not an
Envoy-supported attribute.

See #658.

Co-Authored-By: Thibault Charbonnier <[email protected]>
@thibaultcha thibaultcha force-pushed the feat/request.is_subrequest-merge branch from 8ae948e to 312c4b0 Compare January 17, 2025 00:49
@thibaultcha thibaultcha merged commit 6138510 into main Jan 17, 2025
32 checks passed
@thibaultcha thibaultcha deleted the feat/request.is_subrequest-merge branch January 17, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants